Use absolute value for balancetype using targetP #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Following discussion with @annetill we should make sure factor is an absolute value when using proportional_to_generation_p balance type. This did not make it in the original PR.
What is the current behavior? (You can also link to an open issue here)
No absolute value factor for proportional_to_generation_p balancetype.
What is the new behavior (if this is a feature change)?
Factor value is now absolute for proportional_to_generation_p balancetype.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following: