Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute value for balancetype using targetP #288

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

obrix
Copy link
Member

@obrix obrix commented Apr 26, 2021

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [X ] The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Following discussion with @annetill we should make sure factor is an absolute value when using proportional_to_generation_p balance type. This did not make it in the original PR.

What is the current behavior? (You can also link to an open issue here)

No absolute value factor for proportional_to_generation_p balancetype.

What is the new behavior (if this is a feature change)?

Factor value is now absolute for proportional_to_generation_p balancetype.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix obrix requested a review from annetill April 26, 2021 07:45
@geofjamg geofjamg merged commit 7ef1457 into master Apr 26, 2021
@geofjamg geofjamg deleted the fix_absvalue_targetP_balancetype branch April 26, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants