Support of static var compensator with VoltagePerReactivePowerControl extension #304

annetill · 2021-05-06T09:38:20Z

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

Yes, issue #97

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

If a unique static var compensator with non-zero slope is connected to a bus, regulating voltage locally, the slope attribute is taken into account. I have to increase the unit testing because the more complexe thing in that PR is to deal with all the configurations of generators connected to that bus: with or without slope, regulating voltage or reactive power.

What is the current behavior? (You can also link to an open issue here)

The slope is ignored.

What is the new behavior (if this is a feature change)?

If a unique static var compensator with non-zero slope is connected to a bus, regulating voltage locally, the slope attribute is taken into account.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Add switch PV to PQ. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill · 2021-05-27T06:41:21Z

@annetill Note for that PR: the bus to which the static var compensator is connected is initialized with the nominal voltage. It could be better to start from the targetV value.

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

…tionTerm Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

annetill

Changes requested. I think that you have to do what is done in method createReactivePowerDistributionEquations. You will start with exactly the same lines:

LfBus firstControllerBus = controllerBuses.get(0); // indeed in our case it is aslo the controlled bus.
List<EquationTerm> controllerBusReactiveTerms = createReactiveTerms(firstControllerBus, variableSet, creationParameters);

Then you have to get the slope and the BUS_V term too. Please put of all of that in a dedicated function. In the target vector, you have to use: the ideal targetV, controllerBus.getLoadTargetQ(), controllerBus.getGenerationTargetQ() and try to use DistributionData to store the slope from the equation system to the target evctor. It will be useful later to support several SVCs with slope connected at the same bus.

annetill · 2021-05-31T15:01:05Z

src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystem.java

@@ -364,6 +366,15 @@ private static void createImpedantBranch(LfBranch branch, LfBus bus1, LfBus bus2
            }
            sq1.addTerm(q1);
            branch.setQ1(q1);
+            // Add term slope * Q for svc


Can you introduce an utility method that will be called here and just below? It will make the code more comprehensive.

…f buses with a single SVC with a slope. Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill · 2021-06-03T06:52:16Z

@Hadrien-Godard I am going to rebase the branch on master. The work is not finished because our controller bus with slope can switch PV to PQ, but I think we have to avoid switching them back from PQ to PV in a first approach.

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Hadrien-Godard · 2021-06-03T07:58:42Z

@Hadrien-Godard I am going to rebase the branch on master. The work is not finished because our controller bus with slope can switch PV to PQ, but I think we have to avoid switching them back from PQ to PV in a first approach.

I think we can let them switch PV to PQ in the same manner as classic PV buses.

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix check. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

annetill · 2021-06-15T10:22:49Z

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java

@@ -61,6 +61,8 @@ private static void createVoltageControls(LfNetwork lfNetwork, List<LfBus> lfBus
            List<LfGenerator> voltageControlGenerators = controllerBus.getGenerators().stream().filter(LfGenerator::hasVoltageControl).collect(Collectors.toList());


Here we just have the generators linked to a controller bus. But, what happens in the case where we have two controller buses with each one SVC with slope ? We don't support that configuration too.

annetill · 2021-06-15T10:27:34Z

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java

+                    // we don't support several generators controlling voltage with slope
+                    LOGGER.warn("Non supported: several generators of bus {} control voltage with slope. Slope is therefore deactivated on those generators.", controllerBus);
+                }
+                voltageControlGenerators.forEach(g -> g.setSlope(0));


Why we don't keep one finally ?

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

annetill · 2021-06-17T09:09:14Z

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java


-                VoltageControl voltageControl = controlledBus.getVoltageControl().orElse(new VoltageControl(controlledBus, controllerTargetV));
-                voltageControl.addControllerBus(controllerBus);
+        voltageControls.forEach(LfNetworkLoaderImpl::checkGeneratorsWithSlope);


You can not do that if the parameter is not active, it will be a loss in performances.

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill · 2021-06-22T12:28:30Z

src/main/java/com/powsybl/openloadflow/network/impl/LfStaticVarCompensatorImpl.java

@@ -60,6 +63,9 @@ public double getMaxQ(double p) {
        if (svc.getRegulationMode() == StaticVarCompensator.RegulationMode.VOLTAGE) {
            setVoltageControl(svc.getVoltageSetpoint(), svc.getRegulatingTerminal(), breakers, report);
        }
+        if (svc.getExtension(VoltagePerReactivePowerControl.class) != null) {


Indeed, as we have the parameter in LfNetworkParameters, why we don't use it here? If it is false, can we set the slope to zero?

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

geofjamg · 2021-06-28T07:06:12Z

src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemUpdater.java

+            LfBus controllerBus = controllerBuses.iterator().next();
+            if (!controllerBus.isVoltageControllerEnabled()) {
+                // we only support one controlling static var compensator without any other controlling generators
+                equationSystem.createEquation(controlledBus.getNum(), EquationType.BUS_V_SLOPE).setActive(false);


There is no criteria to switch it on?

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

sonarqubecloud · 2021-06-28T14:48:27Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

90.3% Coverage
0.0% Duplication

annetill added 8 commits May 5, 2021 08:28

Add voltage per reactive power control parameter.

89bd79a

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Add slope in generator attributes.

fd73a3b

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Add GeneratorWithSlopeVoltageEquationTerm.

52a076d

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Introduce new type of bus for equation.

d1a5910

Merge.

d796f3f

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Bug fix.

48dd622

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Add unit tests.

9cc0707

Add switch PV to PQ. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix pom.xml.

5b1c27f

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Hadrien-Godard added 4 commits May 27, 2021 16:59

Add a test with a generator at bus2 not controlling voltage

63fa182

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Using already existing Terms instead of GeneratorWithSlopeVoltageEqua…

911be17

…tionTerm Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Slightly modifying some test results

3dcaa3f

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Typo

465b397

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

annetill commented May 31, 2021

View reviewed changes

annetill mentioned this pull request Jun 1, 2021

New bus pvlq #202

Closed

3 tasks

Hadrien-Godard and others added 4 commits June 2, 2021 15:03

Factorization and using of getGenerationTargetQ for initial targets o…

c177f03

…f buses with a single SVC with a slope. Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Remove a custom print for debug

3ac6154

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Introduce method getGeneratorControllingVoltageWithSlope for LfBus.

13560db

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Clean code.

ebdfdfb

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge.

74c622b

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Switching PQ to PV not supported.

3ff6abb

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill changed the title ~~[WIP] Support of static var compensator with VoltagePerReactivePowerControl extension~~ Support of static var compensator with VoltagePerReactivePowerControl extension Jun 3, 2021

annetill requested a review from flo-dup June 3, 2021 10:19

getGeneratorControllingVoltageWithSlope: lambda changes

c9a5bd1

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

flo-dup force-pushed the svc-slope branch from 506d02f to c9a5bd1 Compare June 4, 2021 08:35

annetill and others added 3 commits June 8, 2021 10:37

Use distribution data.

54591ba

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Add a test for SVC with slope PV -> PQ and blocked.

6e1f8ae

Fix check. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'master' into svc-slope

9e17ff7

Add setSlope to implementations

2b29386

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

annetill commented Jun 15, 2021

View reviewed changes

annetill and others added 3 commits June 15, 2021 14:42

Quick fix for bug.

e8af6f2

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'master' into svc-slope

612ab6c

check generators with slope once voltage controls are created

d8bfc47

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

annetill commented Jun 17, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java Show resolved Hide resolved

flo-dup and others added 6 commits June 21, 2021 10:38

Checking slope only if voltagePerReactivePowerControl is enabled

a94f812

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Update unit test

f4bf98c

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

VoltageControl::isVoltageControlLocal: Correct use and add doc

92dffda

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

LfBus::getGeneratorsControllingVoltageWithSlope returns a list

bce9e12

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Simpler LfNetworkLoaderImpl::checkGeneratorsWithSlope

e3144fc

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Merge.

34a660c

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill commented Jun 22, 2021

View reviewed changes

annetill and others added 2 commits June 22, 2021 15:12

Add a check to verify that the control is local.

e7db88d

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Set slope only if voltagePerReactivePowerControl true

8800755

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

geofjamg reviewed Jun 28, 2021

View reviewed changes

geofjamg approved these changes Jun 28, 2021

View reviewed changes

annetill and others added 7 commits June 28, 2021 11:38

Clean code.

27a04d3

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Remove useless changes.

2a2d28a

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Performance: avoid always filtering out generators based on slope

70ccc31

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Small refactor/renaming

15ae6cc

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

fix

39021d8

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Fix constructor.

df61d8e

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Clean.

1e6b953

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

flo-dup approved these changes Jun 29, 2021

View reviewed changes

flo-dup merged commit 9396b5d into master Jun 29, 2021

flo-dup deleted the svc-slope branch June 29, 2021 07:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support of static var compensator with VoltagePerReactivePowerControl extension #304

Support of static var compensator with VoltagePerReactivePowerControl extension #304

annetill commented May 6, 2021

annetill commented May 27, 2021

annetill left a comment •

edited

Loading

annetill May 31, 2021

annetill commented Jun 3, 2021 •

edited

Loading

Hadrien-Godard commented Jun 3, 2021 •

edited by annetill

Loading

annetill Jun 15, 2021

annetill Jun 15, 2021

annetill Jun 17, 2021

annetill Jun 22, 2021

geofjamg Jun 28, 2021

sonarqubecloud bot commented Jun 28, 2021

		@@ -61,6 +61,8 @@ private static void createVoltageControls(LfNetwork lfNetwork, List<LfBus> lfBus
		List<LfGenerator> voltageControlGenerators = controllerBus.getGenerators().stream().filter(LfGenerator::hasVoltageControl).collect(Collectors.toList());

Support of static var compensator with VoltagePerReactivePowerControl extension #304

Support of static var compensator with VoltagePerReactivePowerControl extension #304

Conversation

annetill commented May 6, 2021

annetill commented May 27, 2021

annetill left a comment • edited Loading

Choose a reason for hiding this comment

annetill May 31, 2021

Choose a reason for hiding this comment

annetill commented Jun 3, 2021 • edited Loading

Hadrien-Godard commented Jun 3, 2021 • edited by annetill Loading

annetill Jun 15, 2021

Choose a reason for hiding this comment

annetill Jun 15, 2021

Choose a reason for hiding this comment

annetill Jun 17, 2021

Choose a reason for hiding this comment

annetill Jun 22, 2021

Choose a reason for hiding this comment

geofjamg Jun 28, 2021

Choose a reason for hiding this comment

sonarqubecloud bot commented Jun 28, 2021

annetill left a comment •

edited

Loading

annetill commented Jun 3, 2021 •

edited

Loading

Hadrien-Godard commented Jun 3, 2021 •

edited by annetill

Loading