Use new parameters isDcUseTransformerRatio and countriesToBalance #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…triesToBalance. Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
…articipating to the computation based on its substation country. Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
…o update debug-parameters.json Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
obrix
changed the title
annetill
reviewed
May 20, 2021
src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
flo-dup
reviewed
May 20, 2021
src/main/java/com/powsybl/openloadflow/OpenLoadFlowProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/outerloop/AcLoadFlowParameters.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/network/LfNetworkParameters.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
|
@flo-dup I aggree, there is a a lot of unnecessary duplications in the parameters class, we should discuss it soon. |
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
annetill
reviewed
May 21, 2021
| @@ -43,7 +43,7 @@ public String getElementType() { | |||
| @Override | |||
| public List<ParticipatingElement> getParticipatingElements(Collection<LfBus> buses) { | |||
| return buses.stream() | |||
| .filter(bus -> !(bus.isDisabled() || bus.isFictitious())) | |||
| .filter(bus -> !(bus.isDisabled() || bus.isFictitious() || !bus.isParticipating())) | |||
There was a problem hiding this comment.
The double negative is not well understandable...
There was a problem hiding this comment.
The alternative is bus.isParticipating() && !bus.isDisabled() && !bus.isFictitious(), I think it is better, do you agree ?
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Use the two new parameters available in powsybl-core isDcUseTransformerRatio and countriesToBalance. The branch for this PR is based on the branch from the PR #295 to use the compatibility work already done for 4.2.0 release candidate.
Thus it is to be rebased and merged after this PR.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)