Generator contingency for DC sensitivities #318

Hadrien-Godard · 2021-06-04T09:19:51Z

Signed-off-by: Hadrien hadrien.godard@artelys.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

annetill

It could be better to do test driven development, but it is up to you.

annetill · 2021-06-09T07:04:40Z

src/main/java/com/powsybl/openloadflow/network/impl/LfBusImpl.java

@@ -87,4 +87,9 @@ public void updateState(boolean reactiveLimits, boolean writeSlackBus, boolean d
    public boolean isParticipating() {
        return participating;
    }
+
+    public void setIsParticipating(boolean b) {


Change for setParticipating and if you change that attribute, do not forget to store it and to restore it after contingency.

annetill · 2021-06-09T07:08:08Z

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

+            generatorsToSave.add(generator);
+        }
+        Map<Generator, GeneratorState> generatorStates = GeneratorState.createGeneratorStates(generatorsToSave);
+        for (String generatorId : contingency.getGeneratorIdsToLose()) {


You have to do that on the LfGenerator object directly and in the same time you have to remove it from slack distribution if in the parameters slack is distributed and the distribution is made on generators.

annetill · 2021-06-09T07:08:57Z

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

+        return generatorStates;
+    }
+
+    private List<ParticipatingElement> removeGeneratorParticipation(Network network, LfNetwork lfNetwork, PropagatedContingency contingency, List<ParticipatingElement> participatingElements) {


I think you don't need a dedicated function for that. It could be done with the other attributes of the generator.

annetill · 2021-06-09T07:10:23Z

src/main/java/com/powsybl/openloadflow/util/GeneratorState.java

+/**
+ * @author Hadrien Godard <hadrien.godard at artelys.com>
+ */
+public class GeneratorState {


You don't need that class, I think that all of this can be done inside BusState. with some adaptions in order not to save all the generators of a bus maybe.

…ed in next commit Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

…ybl/powsybl-open-loadflow into sensiDCGeneratorContingency

geofjamg · 2021-06-17T07:55:20Z

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

-            if (shouldChangeRhs) {
-                setBaseCaseSensitivityValues(factorGroups, factorStates);
-            }
+        List<ParticipatingElement> saveParticipatingElements = new ArrayList<>(participatingElements);


I suspect a serious performance regression, we should have something like before:

if (contingency.getHvdcIdsToOpen().isEmpty() || contingency.getGeneratorIdsToLose().isEmpty()) { calculateSensitivityValues(factors, factorStates, contingenciesStates, flowStates, contingencyElements, contingency, valueWriter); } else { // if we have a contingency including the loss of a DC line or a generator loss }

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

geofjamg · 2021-06-17T09:47:45Z

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

-            if (shouldChangeRhs) {
+            if (changeParticipatingElements) {
+                participatingElements.clear();
+                participatingElements.addAll(saveParticipatingElements);


Is it on purpose the fact that you change the participatingElements method input?

These three lines here are very important yes. What do you mean?

geofjamg · 2021-06-17T10:56:41Z

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

+        }
+    }
+
+    private Map<LfBus, BusState> applyContingencyOnNetwork(Network network, LfNetwork lfNetwork, PropagatedContingency contingency,


The name is confusing as we only apply injection part of the contingency

I have changed in applyInjectionContingencies, what do you think?

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

…ybl/powsybl-open-loadflow into sensiDCGeneratorContingency

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

sonarqubecloud · 2021-06-22T09:35:18Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

90.0% Coverage
0.0% Duplication

Definition of applyGeneratorContingency

94a8e7e

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Hadrien-Godard requested a review from annetill June 4, 2021 09:19

Hadrien-Godard self-assigned this Jun 4, 2021

Hadrien-Godard added 4 commits June 4, 2021 13:51

Store generator states and participating elements before modifying them

3512f22

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Style corrections

0e921c5

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Remove changes on participating

73453f9

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Impact on DC sensitivity analysis

5bf1648

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

annetill requested changes Jun 9, 2021

View reviewed changes

Hadrien-Godard and others added 11 commits June 10, 2021 15:01

Use of LfGenerator rather than Generator. One Unit test should be add…

78003c4

…ed in next commit Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Test

182e586

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Finalize test and debug

283e2bc

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Remove GeneratorState class and use BusState instead

62fe00c

Signed-off-by: Hadrien <hadrien.godard@artelys.com>

Merge branch 'master' into sensiDCGeneratorContingency

ac5b10c

Clean code.

4b7b3cf

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Correct NPE code smell

8077de5

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Correct bug

33aa366

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Fix indentation.

9fe331e

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'master' into sensiDCGeneratorContingency

d292c13

Merge branch 'sensiDCGeneratorContingency' of https://github.com/pows…

a9078e5

…ybl/powsybl-open-loadflow into sensiDCGeneratorContingency

geofjamg requested changes Jun 17, 2021

View reviewed changes

Fix code after review.

cd01194

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill requested a review from geofjamg June 17, 2021 09:24

geofjamg requested changes Jun 17, 2021

View reviewed changes

annetill and others added 7 commits June 17, 2021 16:48

Merge branch 'master' into sensiDCGeneratorContingency

6e49ef7

Apply review comments.

243352d

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'sensiDCGeneratorContingency' of https://github.com/pows…

e6348ff

…ybl/powsybl-open-loadflow into sensiDCGeneratorContingency

Fix code smells.

cbbb4cb

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

No need to have Pair<LfBus, LfGenerator> thanks to LfGenerator::getBus

ff7d36e

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Avoid creating unnecessary lists

a598a55

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Avoid returning busStates

8c56501

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

flo-dup and others added 6 commits June 22, 2021 10:00

Save participating elements only if needed

f4542fd

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Update participating elements *before* setReferenceActivePowerFlows

1b88acd

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Update unit test

821f429

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Fix.

8f40fbf

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Small changes.

e5da219

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'master' into sensiDCGeneratorContingency

839a5ef

geofjamg approved these changes Jun 22, 2021

View reviewed changes

annetill merged commit a05ae20 into master Jun 22, 2021

annetill deleted the sensiDCGeneratorContingency branch June 22, 2021 11:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generator contingency for DC sensitivities #318

Generator contingency for DC sensitivities #318

Hadrien-Godard commented Jun 4, 2021

annetill left a comment

annetill Jun 9, 2021

annetill Jun 9, 2021

annetill Jun 9, 2021

annetill Jun 9, 2021

geofjamg Jun 17, 2021

geofjamg Jun 17, 2021

annetill Jun 21, 2021

geofjamg Jun 17, 2021

annetill Jun 21, 2021

sonarqubecloud bot commented Jun 22, 2021

Generator contingency for DC sensitivities #318

Generator contingency for DC sensitivities #318

Conversation

Hadrien-Godard commented Jun 4, 2021

annetill left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jun 22, 2021