Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security analysis: disconnect terminals of isolated end nodes #325

Merged
merged 6 commits into from
Sep 13, 2021

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jun 29, 2021

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
In security analysis, if an end node is encountered after an openable switch, the corresponding terminal is not disconnected.

Note that originally this PR was opened not to retained switches if they are encountered just before encountering a line / a 2wt while propagating the contingency. But a line / 2wt opened on one side is not equivalent to a disconnected line / 2wt.

What is the new behavior (if this is a feature change)?
In security analysis, if an end node is encountered after an openable switch, the corresponding terminal is disconnected.

Does this PR introduce a breaking change or deprecate an API?
No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup marked this pull request as draft June 29, 2021 13:37
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup marked this pull request as ready for review June 29, 2021 14:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup
Copy link
Contributor Author

flo-dup commented Jun 29, 2021

What happens if while propagating a contingency, we encountered an openable switch which is just before a 3WT? The question being, is the 3WT still working when one of its leg is disconnected?

@flo-dup flo-dup requested a review from geofjamg June 29, 2021 14:13
annetill and others added 2 commits September 9, 2021 13:32
@flo-dup flo-dup changed the title Security analysis: less retained switches Security analysis: disconnect terminals of isolated end nodes Sep 13, 2021
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit f592068 into master Sep 13, 2021
@flo-dup flo-dup deleted the less_retained_switches branch September 13, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants