Fixes in branch results of security analysis #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- q1 was not correctly unscaled from per-unit - current unscaling was bugged, using static variables for nominal voltages Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
flo-dup
approved these changes
Jul 6, 2021
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#327
In addition, the value of
q1was not correctly unscaled.What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug
What is the current behavior? (You can also link to an open issue here)
Static variables are used for the nominal voltages of branches, which leads to using the same nominal voltage to unscale the currents of all branches of the network.
In addition, the value of
q1was not correctly unscaled.What is the new behavior (if this is a feature change)?
Current values and q1 are correctly unscaled. Unit tests are adapted in order to go over that kind of case.