Fix: voltage controls discarded when controller and controlled buses are not in the same SC #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
…nt for generators. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
…omponent for rtc and ptc. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
flo-dup
approved these changes
Oct 13, 2021
| @@ -539,6 +539,10 @@ private static void createPhaseControl(LfNetwork lfNetwork, PhaseTapChanger ptc, | |||
| LOGGER.warn("Regulating terminal of phase controller branch {} is out of voltage: no phase control created", controllerBranch.getId()); | |||
| return; | |||
| } | |||
| if (!isInSameSynchronousComponent(ptc.getRegulationTerminal(), terminal, breakers)) { | |||
| LOGGER.warn("Regulating terminal of controller branch {} is not in the same synchronous component: phase control discarded", controllerBranchId); | |||
There was a problem hiding this comment.
The warning is not the same as the other, phase control discarded instead of no phase control created. But I prefer the new one you chose, it's clearer in fact.
| @@ -586,6 +590,10 @@ private static void createDiscreteVoltageControl(LfNetwork lfNetwork, RatioTapCh | |||
| LOGGER.warn("Controlled bus {} has both generator and transformer voltage control on: only generator control is kept", controlledBus.getId()); | |||
| return; | |||
| } | |||
| if (!isInSameSynchronousComponent(rtc.getRegulationTerminal(), terminal, breakers)) { | |||
| LOGGER.warn("Regulating terminal of controller branch {} is not in the same synchronous component: voltage control discarded", controllerBranchId); | |||
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
flo-dup
approved these changes
Oct 14, 2021
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)