Shunt compensator refactoring #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
annetill
reviewed
Jan 3, 2022
| double qCalc = q.eval(); | ||
| double bSum = shuntCompensators.stream() | ||
| .mapToDouble(ShuntCompensator::getB) | ||
| .sum(); |
There was a problem hiding this comment.
Be careful here because even if we have one or several shunts connected to a bus, the sum could be equal to zero. All b values can be equal to zero, or all b can be non zero value but with a sum equals to zero.
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
reviewed
Jan 3, 2022
| @@ -19,5 +19,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
If we have access to the bus voltage in the LfShunt, we don't need q anymore. @geofjamg what do you think ?
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
SonarCloud Quality Gate failed. |
annetill
reviewed
Jan 3, 2022
| this.shuntCompensator = Objects.requireNonNull(shuntCompensator); | ||
| double nominalV = shuntCompensator.getTerminal().getVoltageLevel().getNominalV(); | ||
| if (shuntCompensators.isEmpty()) { | ||
| throw new IllegalArgumentException("Empty shunt compensator list"); |
There was a problem hiding this comment.
This could not happened indeed, I cannot unit test this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@gmail.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactoring
What is the current behavior? (You can also link to an open issue here)
We create one equation per IIDM shunt compensator.
What is the new behavior (if this is a feature change)?
We now create one equation for all IIDM shunt compensators connected to same bus.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)