Refactor discrete voltage control #413

geofjamg · 2022-01-05T21:49:45Z

Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@gmail.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactoring

What is the current behavior? (You can also link to an open issue here)
To change a discrete voltage control mode, we need to remove and re-create equations

What is the new behavior (if this is a feature change)?
We only need to active/deactivate some equations

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

# Conflicts: # src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystem.java # src/main/java/com/powsybl/openloadflow/network/AbstractElement.java # src/main/java/com/powsybl/openloadflow/network/AbstractLfNetworkListener.java # src/main/java/com/powsybl/openloadflow/network/LfNetworkListener.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

# Conflicts: # src/main/java/com/powsybl/openloadflow/ac/TransformerVoltageControlOuterLoop.java # src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystem.java # src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemUpdater.java # src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationType.java # src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java # src/test/java/com/powsybl/openloadflow/equations/EquationSystemTest.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

annetill · 2022-01-06T08:03:16Z

src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystem.java

+            LfBranch controllerBranch = controllerBranches.get(i);
+
+            // activate all rho1 equations if voltage control is off
+            equationSystem.getEquation(controllerBranch.getNum(), AcEquationType.BRANCH_TARGET_RHO1)


Just to be sure that I understand well: here, later, I will have to take into account the local status of the branch controller, especially if the transformer is at its limits? But for now, we only use the status of the controlled bus.
In my previous tests, I have met a contingency that makes me lost one of the controller branches. This is supported by that PR ?

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill · 2022-01-06T10:16:33Z

src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java

@@ -755,4 +755,66 @@ void testSAmodeACAllBranchMonitoredFlowTransfer() {
        assertEquals(1.66, brl14l13.getP1(), 1e-2);
        assertEquals(0.66, brl14l13.getFlowTransfer(), 1e-2);
    }
+
+    @Test
+    void testSAWithRemoteSharedControl() {


This is not working, look at the logs.

I fixed it. We now have to unit test post contingency reactive power using monitors.

annetill · 2022-01-06T10:17:55Z

src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java

+    @Test
+    void testSAWithTransformerRemoteSharedControl() {
+        // FIXME
+        Network network = VoltageControlNetworkFactory.createWithTransformerSharedRemoteControl();


I am not sure that it is working because in post contingency, we have no transformer voltage control at all. It is totally removed.

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill · 2022-01-09T13:43:04Z

src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java

+        // post-contingency tests
+        PostContingencyResult postContingencyResult = result.getPostContingencyResults().stream().filter(r -> r.getContingency().getId().equals("T2wT")).findFirst().get();
+        assertEquals("T2wT", postContingencyResult.getContingency().getId());
+        assertEquals(0.0, postContingencyResult.getBranchResult("T2wT2").getQ2(), 1e-2); // FIXME


I have tried to solve it before #316

# Conflicts: # src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystem.java # src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemUpdater.java # src/main/java/com/powsybl/openloadflow/network/VoltageControl.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill · 2022-01-11T16:22:55Z

src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java

+    }
+
+    @Test
+    void testSAWithShuntRemoteSharedControl() {


@geofjamg here I don't understand the post contingency value at transformer tr3. Furthermore, if simul shunt is at false, I have a KLU issue...

I don't have the KLU issue on my side

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

geofjamg · 2022-01-12T08:44:44Z

@annetill there is a lot remaining issues with transformer voltage control in SA, but maybe we could just merge this PR as it is (which is far better that main branch) and improve with new PRs? (The initial goal of this PR was just to avoid removing equations)

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

geofjamg · 2022-01-12T08:41:58Z

src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java

+    }
+
+    @Test
+    void testSaWithTransformerRemoteSharedControl() {


Maybe we should remove the "remote" word as it does not make sense for transformer voltage control?

Why? It is a remote control...

geofjamg · 2022-01-12T08:43:12Z

src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java

+        LoadFlowParameters lfParameters = new LoadFlowParameters()
+                .setTransformerVoltageControlOn(true);
+
+        List<Contingency> contingencies = allBranches(network);


When we change this line to only simulate T2wT2 contingency, we don't have same result, which probably means we don't restore state correctly after contingencies

We should keep this as an issue that will be resolved in a dedicate PR.

Fixed in this PR, see last commit.

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

sonarqubecloud · 2022-01-12T12:21:53Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

89.3% Coverage
0.0% Duplication

geofjamg and others added 17 commits November 8, 2021 09:34

Element disabling notification

6b9cd7e

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix

eff37b8

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Refactoring

f5142d5

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Renaming

064d1a7

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Merge

c5144cb

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Refactor bus/branch state

8c84b28

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix branche state

a3a6929

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Cleanup

a4d1293

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Refactoring

3dab170

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Refactoring

3210211

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Refactoring

4676db6

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Refactoring

613fce0

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix

d3ab1c7

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Cleanup

4ac5cfe

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Refactor discrete voltage control

14dae46

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

geofjamg requested a review from annetill January 5, 2022 21:49

Refactor shunt voltage control

20658be

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

geofjamg changed the title ~~[WIP] Refactor discrete voltage control~~ Refactor discrete voltage control Jan 5, 2022

Cleanup

75f6543

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

annetill reviewed Jan 6, 2022

View reviewed changes

geofjamg changed the title ~~Refactor discrete voltage control~~ [WIP] Refactor discrete voltage control Jan 6, 2022

Add some tests.

049da92

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill reviewed Jan 6, 2022

View reviewed changes

geofjamg and others added 4 commits January 6, 2022 21:47

Merge branch 'main' into refactor_discrete_voltage_control

84843c6

Merge

360b542

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Merge branch 'main' into disable_notif

0ae127f

Try to fix SA

a79d21f

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

geofjamg and others added 4 commits January 6, 2022 22:18

Merge branch 'disable_notif' into refactor_discrete_voltage_control

1e865bd

Fix SA

0c7a454

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Add assertions.

440d49a

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix tests.

fd65610

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill reviewed Jan 9, 2022

View reviewed changes

geofjamg and others added 10 commits January 10, 2022 10:56

Fix merge

25cff4d

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Fix security analysis with voltage controls.

ed0a2c3

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix after review.

fbbc424

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix

2959c7e

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix

a503da8

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix KLU issue

4e63cd0

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Merge branch 'main' into refactor_discrete_voltage_control

82d38d9

Fix update in case of local voltage control.

cbd20b0

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Try to improve unit tests.

e01d7fc

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill reviewed Jan 11, 2022

View reviewed changes

annetill and others added 4 commits January 11, 2022 19:48

Fix tests.

1ca5b62

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Cleanup

8d21add

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Cleanup

34784a3

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Cleanup

3bce6f6

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

geofjamg changed the title ~~[WIP] Refactor discrete voltage control~~ Refactor discrete voltage control Jan 12, 2022

Remove TODO.

9912269

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill approved these changes Jan 12, 2022

View reviewed changes

geofjamg commented Jan 12, 2022

View reviewed changes

Fix AS.

750180d

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

geofjamg merged commit 1fc9e92 into main Jan 12, 2022

geofjamg deleted the refactor_discrete_voltage_control branch January 12, 2022 12:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor discrete voltage control #413

Refactor discrete voltage control #413

geofjamg commented Jan 5, 2022 •

edited

Loading

annetill Jan 6, 2022

annetill Jan 6, 2022

geofjamg Jan 6, 2022

annetill Jan 6, 2022

annetill Jan 9, 2022

annetill Jan 11, 2022

geofjamg Jan 12, 2022

geofjamg commented Jan 12, 2022 •

edited

Loading

geofjamg Jan 12, 2022

annetill Jan 12, 2022

geofjamg Jan 12, 2022

geofjamg Jan 12, 2022

annetill Jan 12, 2022

annetill Jan 12, 2022

sonarqubecloud bot commented Jan 12, 2022

Refactor discrete voltage control #413

Refactor discrete voltage control #413

Conversation

geofjamg commented Jan 5, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geofjamg commented Jan 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 12, 2022

geofjamg commented Jan 5, 2022 •

edited

Loading

geofjamg commented Jan 12, 2022 •

edited

Loading