Remove discrete voltage control mode #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
geofjamg
commented
Jan 13, 2022
| @@ -844,7 +844,7 @@ void testSaWithShuntRemoteSharedControl() { | |||
|
|
|||
| // post-contingency tests | |||
| PostContingencyResult tr2ContingencyResult = getPostContingencyResult(result, "tr2"); | |||
| assertEquals(-107.543, tr2ContingencyResult.getBranchResult("tr1").getQ2(), 1e-2); | |||
| assertEquals(107.543, tr2ContingencyResult.getBranchResult("tr3").getQ2(), 1e-2); | |||
| assertEquals(-55.4, tr2ContingencyResult.getBranchResult("tr1").getQ2(), 1e-2); | |||
There was a problem hiding this comment.
No idea why I have a different value... but I am not sure the previous value was ok.
annetill
reviewed
Jan 13, 2022
| @Override | ||
| public void cleanup(LfNetwork network) { | ||
| for (LfBus bus : network.getBuses()) { | ||
| bus.getControllerShunt().ifPresent(controllerShunt -> controllerShunt.setVoltageControlEnabled(false)); |
There was a problem hiding this comment.
Why do you put false here? It should be true, no?
annetill
reviewed
Jan 13, 2022
|
|
||
| return shuntVoltageControls.isEmpty() ? OuterLoopStatus.STABLE : OuterLoopStatus.UNSTABLE; | ||
| for (LfBus bus : context.getNetwork().getBuses()) { | ||
| LfShunt controllerShunt = bus.getControllerShunt().orElse(null); |
There was a problem hiding this comment.
You should check if a shunt voltage control is present.
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@gmail.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)