-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Equation system index optimization #435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
geofjamg
changed the title
Equation system index optimization
[WIP] Equation system index optimization
Jan 24, 2022
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
geofjamg
changed the title
[WIP] Equation system index optimization
Equation system index optimization
Jan 28, 2022
geofjamg
changed the title
Equation system index optimization
[WIP] Equation system index optimization
Jan 29, 2022
# Conflicts: # src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
# Conflicts: # src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com> # Conflicts: # src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java
geofjamg
force-pushed
the
eq_sys_cache_optim
branch
from
April 23, 2022 20:17
f7a9423
to
44be9e8
Compare
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@annetill it should be better now |
…cache_optim # Conflicts: # src/main/java/com/powsybl/openloadflow/equations/EquationSystemIndex.java # src/main/java/com/powsybl/openloadflow/equations/EquationSystemIndexListener.java # src/main/java/com/powsybl/openloadflow/equations/JacobianMatrix.java # src/main/java/com/powsybl/openloadflow/equations/TargetVector.java # src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java # src/test/java/com/powsybl/openloadflow/equations/EquationSystemIndexTest.java
# Conflicts: # src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Jun 3, 2022
annetill
approved these changes
Jun 3, 2022
Hadrien-Godard
pushed a commit
that referenced
this pull request
Jun 7, 2022
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
We do not precisely detect from equation system listener, if the resulting matrix structure has changed (row or column dimension change, or non zero element change).
What is the new behavior (if this is a feature change)?
We added an equation system index listener which is responsible for maintaining a precise few of an equation system change on matrix structure.
=> 10% performance improvement on security analysis
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)