Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronous component check #437

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Fix synchronous component check #437

merged 1 commit into from
Jan 30, 2022

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Jan 29, 2022

Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@gmail.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug

What is the current behavior? (You can also link to an open issue here)
There is a check which is working fine with IIDM implementation from core but not for the one of network store. It is because it relies on Component equality which is not something required by IIDM API.

What is the new behavior (if this is a feature change)?
Check is done using num.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg geofjamg requested a review from annetill January 29, 2022 12:15
@geofjamg geofjamg merged commit 555e3a7 into main Jan 30, 2022
@geofjamg geofjamg deleted the fix_synch_comp_check branch January 30, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants