Remove EquationUtil #447
Merged
Remove EquationUtil #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
# Conflicts: # src/main/java/com/powsybl/openloadflow/network/BusState.java
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
geofjamg
commented
Feb 15, 2022
| @@ -112,6 +109,9 @@ private void calculatePostContingencySensitivityValues(List<LfSensitivityFactor< | |||
| LoadFlowParameters lfParameters, OpenLoadFlowParameters lfParametersExt, | |||
| String contingencyId, int contingencyIndex, SensitivityValueWriter valueWriter, | |||
| Reporter reporter, boolean hasTransformerBusTargetVoltage) { | |||
| for (LfBranch branch : lfContingency.getBranches()) { | |||
There was a problem hiding this comment.
@annetill we can safely replace by LfContingency.apply ?
There was a problem hiding this comment.
It is on my TODO list, I think it should work but I need to add some tests and to perform real tests. My question is: in an AC sensitivity analysis, do you need to support transformers control such as voltage or active power control ? Do we need to support shunt voltage control ?
There was a problem hiding this comment.
For a sensitivity analysis, everything regarding control does not make really sense.
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
# Conflicts: # src/main/java/com/powsybl/openloadflow/sensi/AcSensitivityAnalysis.java
annetill
reviewed
Feb 23, 2022
| equationSystem.getEquation(bus.getNum(), AcEquationType.BUS_TARGET_V) | ||
| .orElseThrow() | ||
| .setActive(false); | ||
| bus.getVoltageControl().ifPresent(voltageControl -> AcEquationSystem.updateGeneratorVoltageControl(voltageControl, equationSystem)); |
There was a problem hiding this comment.
Do you miss controllerBus.getReactivePowerControl().ifPresent here?
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
The
EquationUtilallows to save and restore equations state change because of a contingency.What is the new behavior (if this is a feature change)?
We don't use
EquationUtilanymore but only relies on bus/branch disabling. It means that there is no more direct access to equation system from LF/AS/Sensi. We always interact with theLfNetworkwhich automatically reflects changes to the equation system.Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)