Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a P and Q bus equations for all buses #452

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Feb 18, 2022

Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
p and q calculated injection is not set correctly for AC system, in case of bus with shunt compensator.
The "empty" criteria to set p and q equations to the bus is not correct if some terms have already been added during bus creation.

What is the new behavior (if this is a feature change)?
p and q equations are correctly set for all buses.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg requested a review from annetill February 18, 2022 16:46
@geofjamg geofjamg changed the title Create a P and Q bus equation for all buses Create a P and Q bus equations for all buses Feb 18, 2022
@geofjamg geofjamg changed the title Create a P and Q bus equations for all buses [WIP] Create a P and Q bus equations for all buses Feb 18, 2022
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg geofjamg changed the title [WIP] Create a P and Q bus equations for all buses Create a P and Q bus equations for all buses Feb 18, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg added the bug Something isn't working label Feb 18, 2022
@annetill annetill merged commit 0e72167 into main Feb 21, 2022
@annetill annetill deleted the create_bus_p_q_everywhere branch February 21, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants