Get original ID #494
Merged
Get original ID #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annetill
reviewed
Apr 6, 2022
| @@ -140,6 +140,11 @@ public String getId() { | |||
| return shuntCompensators.stream().map(ShuntCompensator::getId).collect(Collectors.toList()); | |||
There was a problem hiding this comment.
Can we delete this getIds method then?
annetill
reviewed
Apr 6, 2022
| @@ -140,6 +140,11 @@ public String getId() { | |||
| return shuntCompensators.stream().map(ShuntCompensator::getId).collect(Collectors.toList()); | |||
There was a problem hiding this comment.
Can we delete this getIds method then?
|
And what about loads? |
1 similar comment
|
And what about loads? |
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Added |
|
For myself: add unit tests |
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
annetill
reviewed
Apr 8, 2022
| @@ -118,7 +117,7 @@ default double getHighVoltageLimit() { | |||
|
|
|||
| Optional<LfShunt> getControllerShunt(); | |||
|
|
|||
| LfLoads getLfLoads(); | |||
| LfLoads getLoads(); | |||
There was a problem hiding this comment.
You really prefer that name? It is a bit confusing with the Load of IIDM network, no?
There was a problem hiding this comment.
For any other element accessors we did not use lf
annetill
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
There is no strict equivalence between IIDM elements and Lf Network ones. Some elements like loads and shunts are aggregated and some other one a split (3 windings transformers and dangling lines).
What is the new behavior (if this is a feature change)?
We can get list of original IDs for each of the element and for branches a type to get original part of the IIDM element.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)