Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contingency generator for AC computations #500

Merged
merged 5 commits into from
Apr 8, 2022

Conversation

annetill
Copy link
Member

@annetill annetill commented Apr 8, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

No. Bug fix.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

In case of a generator contingency, changing the generator control type is not enough because there is no link with the equation system. The link is between the status of the controller bus and the equation system.

What is the current behavior? (You can also link to an open issue here)

After applying a generator contingency, we have to check that all generators have switch off the voltage control or not. If yes, we change the controller bus status, that will lead to the update of the equation system.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

annetill added 2 commits April 8, 2022 15:22
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill added PR: next-release bug Something isn't working labels Apr 8, 2022
geofjamg and others added 2 commits April 8, 2022 18:28
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.1% 91.1% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit c4b900f into main Apr 8, 2022
@annetill annetill deleted the fix-contingency-generator branch April 8, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR: next-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants