Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determinist branchesToOpen order #516

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Determinist branchesToOpen order #516

merged 2 commits into from
Apr 14, 2022

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Apr 14, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Bug fix (even though the order of branches to remove should not have any impact)

What is the current behavior? (You can also link to an open issue here)
The branches to open set has no determinist order, hence the edges to cut for connectivity computation is in a random order

What is the new behavior (if this is a feature change)?
The branches to open set has a determinist order

Does this PR introduce a breaking change or deprecate an API?
No

flo-dup added 2 commits April 14, 2022 16:34
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup requested a review from geofjamg April 14, 2022 14:54
@flo-dup flo-dup requested review from geofjamg and annetill April 14, 2022 15:02
@flo-dup flo-dup merged commit 2dfb3d5 into main Apr 14, 2022
@flo-dup flo-dup deleted the determinist_branches_order branch April 14, 2022 15:03
@annetill annetill mentioned this pull request Apr 14, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants