Test Metrix for violations in Current, Voltage, Active and Apparent Power #650
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
After just a quick look, I think that you have to create a dedicated factory in order to ass the limits you are using in your tests. In the same network, you can add current, apparent power and active power limits without any conflict. You have to tried to find coherent values and it is better not to change network characteristics (or to explain why you do that). After that, even in tests, we must avoid code duplication. I am sure you can find a way!
|
What is the status of this PR? |
As I said in my comment, this should be done in a dedicated factory in order to be reusable. And the good practice is to find relevant values without any characterictics change. |
…ent Power after a contingency Signed-off-by: cluke <caio.luke@artelys.com>
Signed-off-by: Caio Luke <caio.luke@artelys.com>
Signed-off-by: Caio Luke <caio.luke@artelys.com>
Signed-off-by: Caio Luke <caio.luke@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed!
|
…ower (#650) * add unit tests. * re-organize tests. Signed-off-by: cluke <caio.luke@artelys.com> Co-authored-by: Bertrand Rix <bertrand.rix@artelys.com> Co-authored-by: Anne Tilloy <anne.tilloy@rte-france.com>
ADD: Test Metrix for violations in Current, Voltage, Active and Apparent Power.
Signed-off-by: cluke caio.luke@artelys.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)