Support of three windings transformers as variable or function in sensitivity analysis #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrix
changed the title
annetill
changed the title
annetill
reviewed
Nov 18, 2022
src/test/java/com/powsybl/openloadflow/sensi/ac/AcSensitivityAnalysisTest.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Nov 18, 2022
src/main/java/com/powsybl/openloadflow/sensi/AbstractSensitivityAnalysis.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Nov 18, 2022
src/main/java/com/powsybl/openloadflow/sensi/AbstractSensitivityAnalysis.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Nov 18, 2022
src/main/java/com/powsybl/openloadflow/sensi/AbstractSensitivityAnalysis.java
Outdated
Show resolved
Hide resolved
flo-dup
force-pushed
the
3windingsTranformersInSensi
branch
3 times, most recently
from
dffe1f3 to
386f1a5
Compare
obrix
force-pushed
the
3windingsTranformersInSensi
branch
from
386f1a5 to
bd44446
Compare
|
SonarCloud Quality Gate failed. |
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
force-pushed
the
3windingsTranformersInSensi
branch
from
94b39f6 to
bd44446
Compare
flo-dup
force-pushed
the
3windingsTranformersInSensi
branch
from
bd44446 to
055ff67
Compare
annetill
reviewed
Jan 17, 2023
| List<SensitivityFactor> factors = List.of(factorPhase1, factorPhase2, factorPhase3); | ||
| SensitivityAnalysisResult result = sensiRunner.run(network, factors, Collections.emptyList(), Collections.emptyList(), sensiParameters); | ||
| assertEquals(3, result.getValues().size()); | ||
| // FIXME. |
There was a problem hiding this comment.
@obrix do you remember why I put this FIXME ? Because of the API bug ?
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
# Conflicts: # src/test/java/com/powsybl/openloadflow/sensi/ac/AcSensitivityAnalysisContingenciesTest.java
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
geofjamg
approved these changes
Jan 18, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
flo-dup
reviewed
Jan 18, 2023
| @@ -1177,4 +1218,33 @@ protected static <V extends Enum<V> & Quantity, E extends Enum<E> & Quantity> do | |||
| protected static <V extends Enum<V> & Quantity, E extends Enum<E> & Quantity> double unscaleFunction(LfSensitivityFactor<V, E> factor, double value) { | |||
| return value * getFunctionBaseValue(factor); | |||
| } | |||
|
|
|||
| protected static int getLegNumber(SensitivityFunctionType type) { | |||
There was a problem hiding this comment.
It would make sense to put that int (or Integer) inside the enum, don't you think?
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try supporting three windings transformers in sensitivity analysis.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)