Low impedance threshold into OLF parameters #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 17, 2022 13:00
… OpenLoadFlowParameters and AcEquationSystemCreationParameters Signed-off-by: cluke <caio.luke@artelys.com>
…ializer Signed-off-by: cluke <caio.luke@artelys.com>
…tionParameters *** There are CAIOTODO's to handle Signed-off-by: cluke <caio.luke@artelys.com>
*** There are CAIOTODO's to handle Signed-off-by: cluke <caio.luke@artelys.com>
*** There are CAIOTODO's to handle Signed-off-by: cluke <caio.luke@artelys.com>
… by a lowImpedanceThreshold parameter from either OpenLoadFlowParameters, LfNetworkParameters, AcEquationSystemCreationParameters, DcEquationSystemCreationParameters Signed-off-by: cluke <caio.luke@artelys.com>
annetill
reviewed
Nov 17, 2022
src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java
Outdated
Show resolved
Hide resolved
geofjamg
requested changes
Nov 18, 2022
src/main/java/com/powsybl/openloadflow/FullVoltageInitializer.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/FullVoltageInitializerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/ac/VoltageMagnitudeInitializerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/network/impl/LfSwitchTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/equations/EquationSystemTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: cluke <caio.luke@artelys.com>
|
Can you add a test that shows that it works? |
added 3 commits
November 18, 2022 12:33
…Initializer Signed-off-by: cluke <caio.luke@artelys.com>
Signed-off-by: cluke <caio.luke@artelys.com>
Signed-off-by: cluke <caio.luke@artelys.com>
Just added it, please tell me if it's what you were expecting |
# Conflicts: # src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java
geofjamg
changed the title
geofjamg
approved these changes
Nov 28, 2022
annetill
reviewed
Nov 29, 2022
| @@ -0,0 +1,2 @@ | |||
| open-loadflow-default-parameters: | |||
| lowImpedanceThreshold: 1.0E-2 | |||
There was a problem hiding this comment.
It is not the better value choice even in tests...
annetill
approved these changes
Nov 29, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #651
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)