-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate ConnectivityResult in SA post contingency results #701
Conversation
afe4569
to
08d7f7e
Compare
@@ -75,6 +92,10 @@ public int getIndex() { | |||
return index; | |||
} | |||
|
|||
public int getNbSynchronousComponents() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that here you have to store directly the number of components created by the contingency and add the -1 in that class.
bb87a92
to
528bd1a
Compare
@@ -45,6 +45,7 @@ public void onDisableChange(LfElement element, boolean disabled) { | |||
break; | |||
case BRANCH: | |||
case HVDC: | |||
case SHUNT_COMPENSATOR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@obrix can you remove this fix? We have to open a dedicated PR that shows the bug. Can you open it in parallel and I am going to do a use case. Thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I just opened a separate pull request.
fe6bc7a
to
8dd52f0
Compare
Signed-off-by: Guillaume Verger <guillaume.verger@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
…f lost elements for the contingency. Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
…ation. Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
… toLfContingency. Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
… everything needed is available. Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
8dd52f0
to
d422c84
Compare
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
src/main/java/com/powsybl/openloadflow/sa/DcSecurityAnalysis.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
networkState.restore(); | ||
return connectivityResult; | ||
}) | ||
.orElse(new ConnectivityResult(0, 0, 0, 0, Collections.emptySet())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a API design issue, maybe we should have done this ConnectivityResult optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a PostContingencyResult
, you have a ConnectivityResult
, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bu if you don't have any loss of connectivity for you contingency, you should not provide this object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No... right...
Signed-off-by: Guillaume Verger <guillaume.verger@artelys.com> Co-authored-by: Anne Tilloy <anne.tilloy@rte-france.com> Co-authored-by: Bertrand Rix <bertrand.rix@artelys.com>
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Connectivity Results have been added to the API of Post Contingency Results for Security Analysis (issue: powsybl/powsybl-core#2183, PR: powsybl/powsybl-core#2413)
Here we want to populate these results.
What is the current behavior? (You can also link to an open issue here)
Currently the connectivity results are not computed and a default value is returned.
What is the new behavior (if this is a feature change)?
In the PostContingencyResults, we will now have the number of synchronous components created when applying a contingency, and the load and generation lost.
This PR is not meant to deal with connected components since there is more work to be done with HVDC lines.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)