Support of new BalanceType PROPORTIONAL_TO_GENERATION_PARTICIPATION_FACTOR and PROPORTIONAL_TO_GENERATION_REMAINING_MARGIN #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caioluke be careful your branch seems to be very far from main! You should rebase you dev on main. |
I have rebased it on integration core 5.1.0 snapshot yesterday to be able to use the features I needed from it |
obrix
reviewed
Jan 19, 2023
src/main/java/com/powsybl/openloadflow/network/impl/LfGeneratorImpl.java
Show resolved
Hide resolved
caioluke
force-pushed
the
cgmesNominalPF
branch
from
99d0354 to
fc28fb8
Compare
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Caio Luke <caio.luke@artelys.com>
Signed-off-by: Caio Luke <caio.luke@artelys.com>
Signed-off-by: Caio Luke <caio.luke@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
changed the title
jeandemanged
requested changes
Jan 25, 2023
src/main/java/com/powsybl/openloadflow/network/impl/LfBatteryImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/network/LfGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/network/impl/LfBatteryImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/network/impl/LfGeneratorImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/network/util/GenerationActivePowerDistributionStep.java
Show resolved
Hide resolved
|
sonar report lots of duplicate (relative to the modified code) but I am not so sure of the best way to get rid of the code duplicates without compromising code readability ... should we really do something about it ? |
Signed-off-by: Caio Luke <caio.luke@artelys.com>
annetill
reviewed
Jan 25, 2023
Signed-off-by: Caio Luke <caio.luke@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
annetill
reviewed
Jan 26, 2023
| case TARGET: | ||
| case REMAINING_MARGIN: | ||
| // nothing more to do here | ||
| // the check whether TargetP is within Pmin-Pmax range was already included in generator.isParticipating() |
There was a problem hiding this comment.
was unclear indeed, fixed this way:
// nothing more to do here: the check whether TargetP is within Pmin-Pmax range
// was already made in AbstractLfGenerator#checkActivePowerControl
// whose result is reflected in generator.isParticipating()
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
|
SonarCloud Quality Gate failed. |
annetill
approved these changes
Jan 26, 2023
jeandemanged
approved these changes
Jan 26, 2023
geofjamg
pushed a commit
that referenced
this pull request
Jan 31, 2023
…ACTOR and PROPORTIONAL_TO_GENERATION_REMAINING_MARGIN (#702) Signed-off-by: Caio Luke <caio.luke@artelys.com> Co-authored-by: Anne Tilloy <anne.tilloy@rte-france.com> Co-authored-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires upcoming version of powsybl-core to work
See changes from commit ->
add two new BalanceTypes ...9df191fOther changes come from integration branch
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds support to PROPORTIONAL_TO_GENERATION_PARTICIPATION_FACTOR and PROPORTIONAL_TO_GENERATION_REMAINING_MARGIN in balanceType
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
Relates to
powsybl/powsybl-core#2402
powsybl/powsybl-core#2435
(if any of the questions/checkboxes don't apply, please delete them entirely)