-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remedial action: partial support of GeneratorAction #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlbouchot
commented
Jan 16, 2023
src/main/java/com/powsybl/openloadflow/network/impl/LfGeneratorImpl.java
Outdated
Show resolved
Hide resolved
jlbouchot
commented
Jan 16, 2023
src/main/java/com/powsybl/openloadflow/network/impl/LfGeneratorImpl.java
Outdated
Show resolved
Hide resolved
jlbouchot
commented
Jan 16, 2023
src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfGenerator.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Jan 17, 2023
jlbouchot
force-pushed
the
feature/GeneratorAction
branch
2 times, most recently
from
January 26, 2023 09:33
dc4f422
to
23f1223
Compare
jlbouchot
force-pushed
the
feature/GeneratorAction
branch
from
February 3, 2023 17:18
2829e6a
to
58dadb6
Compare
annetill
reviewed
Feb 7, 2023
src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Feb 7, 2023
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
jlbouchot
force-pushed
the
feature/GeneratorAction
branch
from
February 16, 2023 12:05
58dadb6
to
61a3c18
Compare
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
jlbouchot
changed the title
[WIP] RemedialAction: GeneratorAction implementation
RemedialAction: GeneratorAction implementation
Feb 17, 2023
Note that some work has already been carried over and kept in another branch for whenever we are ready to extend the GeneratorAction to more actions. See https://github.com/powsybl/powsybl-open-loadflow/tree/feature/GeneratorUpdateExtended |
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
…powsybl-open-loadflow into feature/GeneratorAction
annetill
changed the title
RemedialAction: GeneratorAction implementation
Remedial action: partial support of GeneratorAction
Feb 28, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Hadrien-Godard
approved these changes
Mar 2, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Kudos, SonarCloud Quality Gate passed! |
geofjamg
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jean-Luc Bouchot jlbouchot@gmail.com
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)