Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remedial action: partial support of GeneratorAction #704

Merged
merged 36 commits into from
Mar 7, 2023

Conversation

jlbouchot
Copy link
Contributor

Signed-off-by: Jean-Luc Bouchot jlbouchot@gmail.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@jlbouchot jlbouchot marked this pull request as draft January 16, 2023 10:11
@jlbouchot jlbouchot self-assigned this Jan 16, 2023
@obrix obrix removed the prototype label Jan 18, 2023
@jlbouchot jlbouchot force-pushed the feature/GeneratorAction branch 2 times, most recently from dc4f422 to 23f1223 Compare January 26, 2023 09:33
@jlbouchot jlbouchot force-pushed the feature/GeneratorAction branch from 2829e6a to 58dadb6 Compare February 3, 2023 17:18
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
@jlbouchot jlbouchot force-pushed the feature/GeneratorAction branch from 58dadb6 to 61a3c18 Compare February 16, 2023 12:05
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
@jlbouchot jlbouchot changed the title [WIP] RemedialAction: GeneratorAction implementation RemedialAction: GeneratorAction implementation Feb 17, 2023
@jlbouchot jlbouchot marked this pull request as ready for review February 17, 2023 17:49
@jlbouchot
Copy link
Contributor Author

Note that some work has already been carried over and kept in another branch for whenever we are ready to extend the GeneratorAction to more actions. See https://github.com/powsybl/powsybl-open-loadflow/tree/feature/GeneratorUpdateExtended

annetill and others added 9 commits February 20, 2023 11:24
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Jean-Luc Bouchot <jlbouchot@gmail.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill changed the title RemedialAction: GeneratorAction implementation Remedial action: partial support of GeneratorAction Feb 28, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill and others added 9 commits March 7, 2023 10:07
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

90.1% 90.1% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 9475558 into main Mar 7, 2023
@annetill annetill deleted the feature/GeneratorAction branch March 7, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants