Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (or simplify) load action support #741

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Fix (or simplify) load action support #741

merged 4 commits into from
Mar 7, 2023

Conversation

annetill
Copy link
Member

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

No, the issue is raised in supporting generator action.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

It simplifies how to take into account a shift on a load initially at P0. In case of a distributed slack on load, we do:

  • a relative shift is applied as it is on the post-contingency state. If the load participates to slack distribution during previous load flows, we have after contingency P0 + deltaP0 (due to slack). The shift s will lead to a new load P0 equals to P0 + deltaP0 + s ;
  • an absolute shift s is treated as a convention as a relative shift of s - P0 ;
  • in case of the other balance type, the new P0 equals P0 + s (relative) or s (absolute).

What is the current behavior? (You can also link to an open issue here)

The shifts are computed in order to a security analysis with a contingency and a remedial action is totally equivalent to a simple load flow on a network on which we have applied the contingency and the action.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit ac5787b into main Mar 7, 2023
@annetill annetill deleted the improve-load-action branch March 7, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants