Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial support of HvdcAction #744

Merged
merged 13 commits into from
Mar 29, 2023
Merged

Partial support of HvdcAction #744

merged 13 commits into from
Mar 29, 2023

Conversation

annetill
Copy link
Member

@annetill annetill commented Mar 3, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill changed the title WIP: hvdc action from core SNAPSHOT [WIP] hvdc action from core SNAPSHOT Mar 3, 2023
@annetill annetill marked this pull request as draft March 3, 2023 17:26
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill changed the title [WIP] hvdc action from core SNAPSHOT Partial support of HvdcAction Mar 16, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill requested a review from geofjamg March 17, 2023 08:12
@annetill annetill marked this pull request as ready for review March 17, 2023 08:13
annetill and others added 3 commits March 17, 2023 13:00
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill and others added 4 commits March 27, 2023 15:44
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Copy link
Member

@geofjamg geofjamg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Note for later: Our LfAction is begin to be messy. As it is now responsible for many different actions we probably need to design a hierarchy of LfAction instead of putting everything into just one.

@annetill
Copy link
Member Author

Looks good. Note for later: Our LfAction is begin to be messy. As it is now responsible for many different actions we probably need to design a hierarchy of LfAction instead of putting everything into just one.

Yes, but it is also what we are doing for LfContingency, so you want to refactor this class too?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

97.4% 97.4% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 99072c1 into main Mar 29, 2023
@annetill annetill deleted the hvdc-action branch March 29, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants