Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve propagating by dealing with internal connections #774

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Apr 20, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

Too many retained switch when breakers are linked to lines through internal connections

What is the new behavior (if this is a feature change)?
When an internal connection is encountered, looking where it's going to reduce the number of retained switches

Does this PR introduce a breaking change or deprecate an API?
No

@flo-dup flo-dup requested review from geofjamg and annetill April 20, 2023 12:50
flo-dup added 6 commits April 20, 2023 15:18
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the improve_propagating branch from b4a0263 to 403397e Compare April 20, 2023 13:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.7% 98.7% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.7% 98.7% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit 3be31f7 into main Jun 6, 2023
@geofjamg geofjamg deleted the improve_propagating branch June 6, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants