Add parameter to set the min nominal voltage for target voltage check #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
geofjamg
approved these changes
Jun 7, 2023
|
Thanks for the review ! I think that the delete of some parameters in DC is safe, if you confirm, let's merge ! |
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
pushed a commit
that referenced
this pull request
Jun 7, 2023
…#795) Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
All generators that have a target voltage outside of plausible values are discarded from voltage control.
What is the new behavior (if this is a feature change)?
Only generator with a nominal voltage greater that a threshold could be discarded from voltage control if target voltage is outide of plausible values.
Does this PR introduce a breaking change or deprecate an API?
Other information: