Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero impedance branch flows in presence of shunt compensators #797

Merged
merged 10 commits into from
Jun 14, 2023
Merged

Fix zero impedance branch flows in presence of shunt compensators #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c5a3d46
reproduce issue
jeandemanged Jun 12, 2023
ef85ba4
Fix proposal.
annetill Jun 12, 2023
d43c68d
Fix for P.
annetill Jun 12, 2023
feb7b83
Add more unitary tests
marqueslanauja Jun 12, 2023
4eb06ed
Fix proposal (2).
annetill Jun 12, 2023
c899796
make zero impedance flow computation deterministic
zamarrenolm Jun 12, 2023
bf3b925
Clean unit tests.
annetill Jun 12, 2023
e0a1532
Increase coverage (try).
annetill Jun 13, 2023
4020ec4
Revert test.
annetill Jun 13, 2023
e04e1a2
Florian's refactoring.
annetill Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ private static void createShuntEquation(LfShunt shunt, LfBus bus, EquationSystem
shunt.setQ(q);
ShuntCompensatorActiveFlowEquationTerm p = new ShuntCompensatorActiveFlowEquationTerm(shunt, bus, equationSystem.getVariableSet());
equationSystem.createEquation(bus, AcEquationType.BUS_TARGET_P).addTerm(p);
shunt.setP(p);
}

private static void createShuntEquations(LfBus bus, EquationSystem<AcVariableType, AcEquationType> equationSystem) {
Expand Down
12 changes: 12 additions & 0 deletions src/main/java/com/powsybl/openloadflow/network/AbstractLfShunt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ public abstract class AbstractLfShunt extends AbstractElement implements LfShunt

private Evaluable q = EvaluableConstants.NAN;

private Evaluable p = EvaluableConstants.NAN;

protected AbstractLfShunt(LfNetwork network) {
super(network);
}
Expand All @@ -29,4 +31,14 @@ public Evaluable getQ() {
public void setQ(Evaluable q) {
this.q = q;
}

@Override
public Evaluable getP() {
return p;
}

@Override
public void setP(Evaluable p) {
this.p = p;
}
}
4 changes: 4 additions & 0 deletions src/main/java/com/powsybl/openloadflow/network/LfShunt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ default double getBMagnitude() {

List<Controller> getControllers();

Evaluable getP();

void setP(Evaluable evaluable);

Evaluable getQ();

void setQ(Evaluable evaluable);
Expand Down
30 changes: 16 additions & 14 deletions src/main/java/com/powsybl/openloadflow/network/util/ZeroImpedanceFlows.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,12 @@
*/
package com.powsybl.openloadflow.network.util;

import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;

import com.powsybl.openloadflow.network.LoadFlowModel;
import com.powsybl.openloadflow.network.*;
import org.jgrapht.Graph;
import org.jgrapht.alg.interfaces.SpanningTreeAlgorithm;

import com.powsybl.openloadflow.network.LfBranch;
import com.powsybl.openloadflow.network.LfBus;
import java.util.*;
import java.util.stream.Collectors;

/**
* @author Luma Zamarreño <zamarrenolm at aia.es>
Expand All @@ -42,7 +33,7 @@ public ZeroImpedanceFlows(Graph<LfBus, LfBranch> zeroImpedanceSubGraph, Spanning
public void compute() {
Set<LfBus> processed = new HashSet<>();

graph.vertexSet().forEach(lfBus -> {
graph.vertexSet().stream().sorted(Comparator.comparingInt(LfElement::getNum)).forEach(lfBus -> {
if (processed.contains(lfBus)) {
return;
}
Expand Down Expand Up @@ -131,8 +122,11 @@ private void updateFlows(LoadFlowModel loadFlowModel) {
private PQ balanceWithImpedance(LfBus bus, LoadFlowModel loadFlowModel) {
// balance considering injections and flow from lines with impedance

double pShunt = getPShunt(bus.getShunt()) + getPShunt(bus.getControllerShunt()) + getPShunt(bus.getSvcShunt());
double qShunt = getQShunt(bus.getShunt()) + getQShunt(bus.getControllerShunt()) + getQShunt(bus.getSvcShunt());

// take care of the sign
PQ balancePQ = new PQ(-bus.getP().eval(), -bus.getQ().eval());
PQ balancePQ = new PQ(-bus.getP().eval() + pShunt, -bus.getQ().eval() + qShunt);

// only lines with impedance
List<LfBranch> adjacentBranchesWithImpedance = bus.getBranches().stream()
Expand All @@ -147,6 +141,14 @@ private PQ balanceWithImpedance(LfBus bus, LoadFlowModel loadFlowModel) {
return balancePQ;
}

private static double getPShunt(Optional<LfShunt> optionalLfShunt) {
return optionalLfShunt.map(shunt -> shunt.getP().eval()).filter(val -> !Double.isNaN(val)).orElse(0.0);
}

private static double getQShunt(Optional<LfShunt> optionalLfShunt) {
return optionalLfShunt.map(shunt -> shunt.getQ().eval()).filter(val -> !Double.isNaN(val)).orElse(0.0);
}

private PQ getDescendantZeroImpedanceFlow(Map<LfBus, PQ> descendantZeroImpedanceFlow, LfBus bus) {
return descendantZeroImpedanceFlow.containsKey(bus) ? descendantZeroImpedanceFlow.get(bus) : new PQ(0.0, 0.0);
}
Expand Down
103 changes: 102 additions & 1 deletion src/test/java/com/powsybl/openloadflow/ZeroImpedanceFlowsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@
import com.powsybl.iidm.network.DanglingLine;
import com.powsybl.iidm.network.Line;
import com.powsybl.iidm.network.Network;
import com.powsybl.iidm.network.StaticVarCompensator.RegulationMode;
import com.powsybl.iidm.network.Terminal;
import com.powsybl.iidm.network.ThreeWindingsTransformer;
import com.powsybl.iidm.network.TwoWindingsTransformer;
import com.powsybl.iidm.network.extensions.StandbyAutomatonAdder;
import com.powsybl.loadflow.LoadFlow;
import com.powsybl.loadflow.LoadFlowParameters;
import com.powsybl.loadflow.LoadFlowResult;
Expand Down Expand Up @@ -73,6 +75,82 @@ void threeBusesZeroImpedanceLineTest() {
checkFlows(1.99, 1, l23.getTerminal1(), -1.99, -1, l23.getTerminal2());
}

@Test
void threeBusesZeroImpedanceLineWithFixedShuntTest() {
Network network = Network.create("ThreeBusesWithZeroImpedanceLineFixedShunt", "code");
Bus b1 = createBus(network, "b1");
Bus b2 = createBus(network, "b2");
Bus b3 = createBus(network, "b3");
createGenerator(b1, "g1", 2, 1);
createLoad(b3, "l1", 1.00, 0.5);
createLoad(b3, "l2", 0.99, 0.5);
createFixedShuntCompensator(b3, "sh1", 0.2, 0.3);
Line l12 = createLine(network, b1, b2, "l12", 0.1);
Line l23 = createLine(network, b2, b3, "l23", 0.0);

parametersExt.setSlackBusId("b1_vl_0")
.setSlackBusSelectionMode(SlackBusSelectionMode.NAME)
.setNewtonRaphsonConvEpsPerEq(0.000001);
LoadFlowResult result = loadFlowRunner.run(network, parameters);
assertTrue(result.isOk());

checkFlows(-l12.getTerminal2().getP(), -l12.getTerminal2().getQ(), l23.getTerminal1(), l12.getTerminal2().getP(), l12.getTerminal2().getQ(), l23.getTerminal2());
}

@Test
void threeBusesZeroImpedanceLineWithShuntCompensatorTest() {
Network network = Network.create("ThreeBusesWithZeroImpedanceLineShuntCompensator", "code");
Bus b1 = createBus(network, "b1");
Bus b2 = createBus(network, "b2");
Bus b3 = createBus(network, "b3");
createGenerator(b1, "g1", 2, 1);
createLoad(b3, "l1", 1.00, 0.5);
createLoad(b3, "l2", 0.99, 0.5);
createShuntCompensator(b3, "sh1", 0.2, 0.3, 1.0, true);
Line l12 = createLine(network, b1, b2, "l12", 0.1);
Line l23 = createLine(network, b2, b3, "l23", 0.0);

parametersExt.setSlackBusId("b1_vl_0")
.setSlackBusSelectionMode(SlackBusSelectionMode.NAME)
.setNewtonRaphsonConvEpsPerEq(0.000001);
parameters.setShuntCompensatorVoltageControlOn(true);
LoadFlowResult result = loadFlowRunner.run(network, parameters);
assertTrue(result.isOk());

checkFlows(-l12.getTerminal2().getP(), -l12.getTerminal2().getQ(), l23.getTerminal1(), l12.getTerminal2().getP(), l12.getTerminal2().getQ(), l23.getTerminal2());
}

@Test
void threeBusesZeroImpedanceLineWithStandByAutomatonTest() {
Network network = Network.create("threeBusesZeroImpedanceLineWithStandByAutomatonTest", "code");
Bus b1 = createBus(network, "b1");
Bus b2 = createBus(network, "b2");
Bus b3 = createBus(network, "b3");
createGenerator(b1, "g1", 2, 1);
createLoad(b3, "l1", 1.00, 0.5);
createLoad(b3, "l2", 0.99, 0.5);
createStaticVarCompensator(b3, "svc1", 0.3, 0.97, RegulationMode.VOLTAGE);
network.getStaticVarCompensator("svc1")
.newExtension(StandbyAutomatonAdder.class)
.withHighVoltageThreshold(1.2)
.withLowVoltageThreshold(0.8)
.withLowVoltageSetpoint(0.90)
.withHighVoltageSetpoint(1.10)
.withB0(-0.005f)
.withStandbyStatus(true)
.add();
Line l12 = createLine(network, b1, b2, "l12", 0.1);
Line l23 = createLine(network, b2, b3, "l23", 0.0);

parametersExt.setSlackBusId("b1_vl_0")
.setSlackBusSelectionMode(SlackBusSelectionMode.NAME)
.setNewtonRaphsonConvEpsPerEq(0.000001);
LoadFlowResult result = loadFlowRunner.run(network, parameters);
assertTrue(result.isOk());

checkFlows(-l12.getTerminal2().getP(), -l12.getTerminal2().getQ(), l23.getTerminal1(), l12.getTerminal2().getP(), l12.getTerminal2().getQ(), l23.getTerminal2());
}

@Test
void threeBusesZeroImpedanceParallelLinesTest() {
Network network = Network.create("ThreeBusesWithZeroImpedanceParallelLines", "code");
Expand Down Expand Up @@ -152,7 +230,7 @@ void threeBusesZeroImpedanceTwoWindingsTransformerTest() {
}

@Test
void fiveBusesZeroImpedanceTwoWindingsTransforemrTest() {
void fiveBusesZeroImpedanceTwoWindingsTransformerTest() {
Network network = Network.create("FiveBusesWithZeroImpedanceTwoWindingsTransformer", "code");
Bus b1 = createBus(network, "b1");
Bus b2 = createBus(network, "b2");
Expand Down Expand Up @@ -405,6 +483,29 @@ void threeBusesZeroImpedanceDanglingLineDcTest() {
assertTrue(Double.isNaN(dl3.getTerminal().getQ()));
}

@Test
void threeBusesZeroImpedanceLineWithFixedShuntDcTest() {
Network network = Network.create("ThreeBusesWithZeroImpedanceLineWithFixedShuntDc", "code");
Bus b1 = createBus(network, "b1");
Bus b2 = createBus(network, "b2");
Bus b3 = createBus(network, "b3");
createGenerator(b1, "g1", 2, 1);
createLoad(b3, "l1", 1.9, 1);
createLoad(b3, "l2", 1.0, 0.5);
createFixedShuntCompensator(b3, "sh1", 0.2, 0.3);
Line l12 = createLine(network, b1, b2, "l12", 0.01);
Line l23 = createLine(network, b2, b3, "l23", 0.0);

parametersExt.setSlackBusId("b1_vl_0")
.setSlackBusSelectionMode(SlackBusSelectionMode.NAME)
.setNewtonRaphsonConvEpsPerEq(0.000001);
parameters.setDc(true);
LoadFlowResult result = loadFlowRunner.run(network, parameters);
assertTrue(result.isOk());

checkFlows(-l12.getTerminal2().getP(), -l12.getTerminal2().getQ(), l23.getTerminal1(), l12.getTerminal2().getP(), l12.getTerminal2().getQ(), l23.getTerminal2());
}

/**
* l14
* ---------------------------
Expand Down
9 changes: 9 additions & 0 deletions src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowTwoBusNetworkTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,4 +153,13 @@ void withAnAdditionalBattery3() {
assertReactivePowerEquals(-1.0999, line1.getTerminal2());
assertActivePowerEquals(0.600, network.getBattery("bt2").getTerminal());
}

@Test
void zeroImpedanceToShuntCompensator() {
var network = TwoBusNetworkFactory.createZeroImpedanceToShuntCompensator();
LoadFlowResult result = loadFlowRunner.run(network, parameters);
assertTrue(result.isOk());
assertReactivePowerEquals(0.9038788263615884, network.getLine("l23").getTerminal1());
assertActivePowerEquals(0.0, network.getLine("l23").getTerminal1());
}
}
58 changes: 58 additions & 0 deletions src/test/java/com/powsybl/openloadflow/network/AbstractLoadFlowNetworkFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
package com.powsybl.openloadflow.network;

import com.powsybl.iidm.network.*;
import com.powsybl.iidm.network.StaticVarCompensator.RegulationMode;

/**
* @author Geoffroy Jamgotchian <geoffroy.jamgotchian at rte-france.com>
Expand Down Expand Up @@ -211,5 +212,62 @@ protected static HvdcLine createHvdcLine(Network network, String id, HvdcConvert
.setMaxP(activePowerSetpoint)
.add();
}

protected static ShuntCompensator createFixedShuntCompensator(Bus bus, String id, double gPerSection, double bPersection) {
ShuntCompensator sh = bus.getVoltageLevel()
.newShuntCompensator()
.setId(id)
.setBus(bus.getId())
.setConnectableBus(bus.getId())
.setSectionCount(1)
.newLinearModel()
.setGPerSection(gPerSection)
.setBPerSection(bPersection)
.setMaximumSectionCount(1)
.add()
.add();
return sh;
}

protected static ShuntCompensator createShuntCompensator(Bus bus, String id, double g, double b, double v,
boolean voltageControl) {
ShuntCompensator sh = bus.getVoltageLevel()
.newShuntCompensator()
.setId(id)
.setBus(bus.getId())
.setConnectableBus(bus.getId())
.setSectionCount(1)
.newNonLinearModel()
.beginSection()
.setB(b)
.setG(g)
.endSection()
.add()
.add();
sh.setTargetV(v)
.setRegulatingTerminal(sh.getTerminal())
.setTargetDeadband(0.0)
.setVoltageRegulatorOn(voltageControl);
return sh;
}

protected static StaticVarCompensator createStaticVarCompensator(Bus bus, String id, double qSetpoint,
double vSetpoint, RegulationMode regulationMode) {
StaticVarCompensator svc = bus.getVoltageLevel()
.newStaticVarCompensator()
.setId(id)
.setBus(bus.getId())
.setConnectableBus(bus.getId())
.setBmin(-1.0)
.setBmax(1.0)
.setRegulationMode(RegulationMode.OFF)
.add();
svc.setRegulatingTerminal(svc.getTerminal())
.setVoltageSetpoint(vSetpoint)
.setReactivePowerSetpoint(qSetpoint)
.setRegulationMode(regulationMode);

return svc;
}
}

19 changes: 19 additions & 0 deletions src/test/java/com/powsybl/openloadflow/network/TwoBusNetworkFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,23 @@ public static Network create() {
createLine(network, b1, b2, "l12", 0.1f);
return network;
}

public static Network createZeroImpedanceToShuntCompensator() {
Network network = create();
Bus b2 = network.getBusBreakerView().getBus("b2");
Bus b3 = createOtherBus(network, "b3", b2.getVoltageLevel().getId());
createLine(network, b2, b3, "l23", 0.0); // zero impedance
b3.getVoltageLevel().newShuntCompensator()
.setId("sc")
.setName("sc")
.setConnectableBus(b3.getId())
.setBus(b3.getId())
.setSectionCount(1)
.newLinearModel()
.setBPerSection(-2.0)
.setMaximumSectionCount(1)
.add()
.add();
return network;
}
}