Fix already converged case in fast restart mode #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
annetill
reviewed
Jun 26, 2023
| @@ -333,4 +332,13 @@ void testSwitchClose() { | |||
| assertActivePowerEquals(301.884, l1.getTerminal1()); | |||
| assertActivePowerEquals(301.884, l2.getTerminal1()); | |||
| } | |||
|
|
|||
| @Test | |||
| void testInvalidNetwork() { | |||
There was a problem hiding this comment.
Maybe you have to put in our test a first run before setting the targetV to show the cache use.
There was a problem hiding this comment.
Ok I do that but there is a lot a change to do because, target v is not rechecked after restart in the actual code
There was a problem hiding this comment.
Yes, but it is was we do in LfAction indeed.
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
geofjamg
changed the title
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
changed the title
annetill
reviewed
Jun 30, 2023
| lfBus.setGeneratorVoltageControlEnabled(false); | ||
| } | ||
| } | ||
| context.getNetwork().validate(LoadFlowModel.AC, null); |
There was a problem hiding this comment.
Just a question: what is the behavior of the code in case of a fast restart with a targetV change in a DC loadflow mode?
There was a problem hiding this comment.
I have checked, all is good in DC mode. No cache used.
annetill
approved these changes
Jun 30, 2023
jeandemanged
pushed a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com> (cherry picked from commit fbc684f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
In fast restart mode, when re-running a LF without any network change we get a FAILED status.
What is the new behavior (if this is a feature change)?
We get a CONVERGED status (in really this should be a ALREADY_CONVERGED)
Does this PR introduce a breaking change or deprecate an API?
Other information: