Clean indexed terms when removing an equation #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
annetill
reviewed
Jun 30, 2023
| @@ -152,6 +152,14 @@ public Equation<V, E> removeEquation(int num, E type) { | |||
| if (equation != null) { | |||
| Pair<ElementType, Integer> element = Pair.of(type.getElementType(), num); | |||
| equationsByElement.get(element).remove(equation); | |||
| if (equationTermsByElement != null) { | |||
There was a problem hiding this comment.
This is not working on my case and I don't know exactly why. If I put
public Equation<V, E> removeEquation(int num, E type) {
Pair<Integer, E> p = Pair.of(num, type);
Equation<V, E> equation = equations.remove(p);
if (equation != null) {
Pair<ElementType, Integer> element = Pair.of(type.getElementType(), num);
equationsByElement.get(element).remove(equation);
equationTermsByElement = null;
indexAllTerms();
notifyEquationChange(equation, EquationEventType.EQUATION_REMOVED);
}
return equation;
}
There was a problem hiding this comment.
it is supposed to be equivalent but faster. The way you did it reindex everything which would be very slow.
There was a problem hiding this comment.
looking at test case I did, does it seem ok?
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Jun 30, 2023
jeandemanged
pushed a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com> (cherry picked from commit c4d6405)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When an equation is removed, corresponding indexed terms are not cleaned.
Does this PR introduce a breaking change or deprecate an API?
Other information: