Substation automation system #811

geofjamg · 2023-07-03T09:07:40Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the new behavior (if this is a feature change)?
We can simulate overload management systems.

Does this PR introduce a breaking change or deprecate an API?

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

# Conflicts: # src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java # src/test/resources/debug-parameters.json

# Conflicts: # src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java # src/main/java/com/powsybl/openloadflow/OpenLoadFlowProvider.java # src/main/java/com/powsybl/openloadflow/network/LfNetworkParameters.java # src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBranch.java # src/main/java/com/powsybl/openloadflow/network/impl/Networks.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java # src/test/resources/debug-parameters.json

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

# Conflicts: # src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java # src/main/java/com/powsybl/openloadflow/ac/AcloadFlowEngine.java # src/main/java/com/powsybl/openloadflow/network/LfNetworkParameters.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java # src/test/resources/debug-parameters.json

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

sonarqubecloud · 2023-07-03T09:10:14Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

89.3% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

annetill · 2023-07-03T18:21:32Z

src/main/java/com/powsybl/openloadflow/DefaultAcOuterLoopConfig.java

@@ -84,6 +84,10 @@ public List<AcOuterLoop> configure(LoadFlowParameters parameters, OpenLoadFlowPa
        if (parameters.isShuntCompensatorVoltageControlOn()) {
            outerLoops.add(createShuntVoltageControlOuterLoop(parametersExt));
        }
+        // automation functions


The sequence of outer loops becomes to be a bit hard to follow : why this order and why not another one? And for example, what is the behavior when you have a tap changer with voltage control in incremental mode and automatons? What is the sequence? And phase shifters?

annetill · 2023-07-03T18:22:46Z

src/main/java/com/powsybl/openloadflow/ac/outerloop/AutomationSystemOuterLoop.java

+                    LOGGER.debug("Line '{}' is overloaded ({} A > {} A), {} switch '{}'",
+                            branch.getId(), i1 * ib, threshold * ib, system.isSwitchOpen() ? "open" : "close",
+                            system.getSwitchToOperate().getId());
+                    system.getSwitchToOperate().setDisabled(system.isSwitchOpen());


When you disabled a switch, I think you have to make a small connectivity analysis to be sure that nothing else is disabled. Same remark when it is enabled. See LfAction for that.

annetill · 2023-08-30T12:44:32Z

src/main/java/com/powsybl/openloadflow/network/extensions/OverloadManagementSystemAdder.java

+
+    OverloadManagementSystemAdder<T> withThreshold(double threshold);
+
+    OverloadManagementSystemAdder<T> withSwitchIdToOperate(String switchId);


We must think about a switch or a branch side I think.

But we should before correctly handle line disconnected at only one side

# Conflicts: # src/main/java/com/powsybl/openloadflow/DefaultAcOuterLoopConfig.java # src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java # src/main/java/com/powsybl/openloadflow/network/LfNetwork.java # src/main/java/com/powsybl/openloadflow/network/LfNetworkParameters.java # src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java # src/main/java/com/powsybl/openloadflow/network/impl/Networks.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java # src/test/resources/debug-parameters.json

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

# Conflicts: # src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java # src/main/java/com/powsybl/openloadflow/network/LfNetworkParameters.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java # src/test/resources/debug-parameters.json

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

annetill · 2023-10-19T07:05:50Z

...main/java/com/powsybl/openloadflow/network/impl/extensions/OverloadManagementSystemImpl.java

+    }
+
+    @Override
+    public String getSwitchIdToOperate() {


This kind of automation system could use a switch between bus bar sections as remedial action. But most of the time, it is a switch from a line extremity. In that case, I think it is better to model it as a terminal ref (or equipment + side) for performance issue. I think it is the same idea for protection schemes.

Sure, but this is something that will be in addition to switch operation and that cannot be implemented right now in OLF because we don't know open a branch at only one side during the simulation

annetill · 2023-10-20T08:12:15Z

src/main/java/com/powsybl/openloadflow/network/impl/extensions/OverloadManagementSystem.java

+
+    void setEnabled(boolean enabled);
+
+    String getLineIdToMonitor();


Line or Branch ?

monitoredBranch?

From my knowledge, this kind of system are only used on lines

MonitoredLine?

Can you add that you look at side 1?

We should be able to configure it. This is a first and simple version.

src/main/java/com/powsybl/openloadflow/network/impl/extensions/OverloadManagementSystem.java

annetill · 2023-10-20T08:22:02Z

src/main/java/com/powsybl/openloadflow/network/LfNetworkParameters.java

@@ -156,7 +160,9 @@ public LfNetworkParameters(LfNetworkParameters other) {
        this.secondaryVoltageControl = other.secondaryVoltageControl;
        this.cacheEnabled = other.cacheEnabled;
        this.asymmetrical = other.asymmetrical;
+        this.linePerUnitMode = other.linePerUnitMode;


annetill · 2023-10-20T08:31:08Z

src/main/java/com/powsybl/openloadflow/network/impl/Networks.java

+            SubstationAutomationSystems systems = substation.getExtension(SubstationAutomationSystems.class);
+            if (systems != null) {
+                for (OverloadManagementSystem system : systems.getOverloadManagementSystems()) {
+                    addSwitchesOperatedByAutomationSystem(network, topoConfig, system);


We usually say addSwitchesToOperateBy... to be coherent why the rest of the code.

But this is an hypothetical use of the switch. This is not necessarily to operate.

As in remedial actions, it is hypothetical.

As you wish

src/main/java/com/powsybl/openloadflow/ac/outerloop/AutomationSystemOuterLoop.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

# Conflicts: # src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java # src/test/resources/debug-parameters.json

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

annetill · 2023-11-02T10:52:45Z

src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java

@@ -271,7 +273,8 @@ private static <E extends Enum<E>> List<Object> getEnumPossibleValues(Class<E> e
        new Parameter(MAX_VOLTAGE_CHANGE_STATE_VECTOR_SCALING_MAX_DPHI_PARAM_NAME, ParameterType.DOUBLE, "Max voltage angle change for the max voltage change state vector scaling", MaxVoltageChangeStateVectorScaling.DEFAULT_MAX_DPHI),
        new Parameter(LINE_PER_UNIT_MODE_PARAM_NAME, ParameterType.STRING, "Line per unit mode", LinePerUnitMode.IMPEDANCE.name(), getEnumPossibleValues(LinePerUnitMode.class)),
        new Parameter(USE_LOAD_MODEL_PARAM_NAME, ParameterType.BOOLEAN, "Use load model (with voltage dependency) for simulation", LfNetworkParameters.USE_LOAD_MODE_DEFAULT_VALUE),
-        new Parameter(DC_APPROXIMATION_TYPE_PARAM_NAME, ParameterType.STRING, "DC approximation type", DcEquationSystemCreationParameters.DC_APPROXIMATION_TYPE_DEFAULT_VALUE.name(), getEnumPossibleValues(DcApproximationType.class))
+        new Parameter(DC_APPROXIMATION_TYPE_PARAM_NAME, ParameterType.STRING, "DC approximation type", DcEquationSystemCreationParameters.DC_APPROXIMATION_TYPE_DEFAULT_VALUE.name(), getEnumPossibleValues(DcApproximationType.class)),
+        new Parameter(SIMULATE_AUTOMATION_SYSTEMS_PARAM_NAME, ParameterType.BOOLEAN, "Automatons simulation", LfNetworkParameters.SIMULATE_AUTOMATION_SYSTEMS_DEFAULT_VALUE)


Automatons simulation? For coherence, automation systems simulation maybe.

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

# Conflicts: # src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java

sonarqubecloud · 2023-11-10T09:14:27Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

90.6% Coverage
0.0% Duplication

geofjamg and others added 15 commits February 19, 2023 17:26

Current limit automaton simulation

436c7ae

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

c9ab21c

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

9a8f3cf

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Merge branch 'main' into automaton2

b4c96c8

# Conflicts: # src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java # src/test/resources/debug-parameters.json

Fix merge

34c92a0

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

b72f94b

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

ea20d1a

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

8a4289a

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

47e6c63

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

6ac7542

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

2f143e9

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

a414875

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Fix

77134c9

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

annetill requested changes Aug 30, 2023

View reviewed changes

geofjamg added 10 commits October 16, 2023 10:00

Wip

7331cdf

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

db356e2

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

211eaa5

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

4f1fea3

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

bd6f307

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

b201e49

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

7518849

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

c7f61ad

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

geofjamg changed the title ~~[WIP] Automation system~~ Substation automation system Oct 16, 2023

geofjamg requested a review from annetill October 16, 2023 20:09

Wip

83faddf

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

geofjamg requested a review from annetill October 17, 2023 10:49

geofjamg added the ready-for-review label Oct 17, 2023

geofjamg added 2 commits October 17, 2023 21:44

Merge branch 'main' into automaton2

2bd65b2

Merge branch 'main' into automaton2

58ecdf3

annetill reviewed Oct 19, 2023

View reviewed changes

annetill reviewed Oct 20, 2023

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/impl/extensions/OverloadManagementSystem.java Show resolved Hide resolved

annetill reviewed Oct 20, 2023

View reviewed changes

geofjamg requested a review from annetill October 20, 2023 10:53

annetill reviewed Oct 20, 2023

View reviewed changes

src/main/java/com/powsybl/openloadflow/ac/outerloop/AutomationSystemOuterLoop.java Show resolved Hide resolved

geofjamg added 8 commits October 20, 2023 13:03

Fix

dc4f77e

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Merge remote-tracking branch 'origin/automaton2' into automaton2

f168409

Wip

a1dc2b8

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

9018a6e

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

b96d523

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

f77f136

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Merge branch 'main' into automaton2

51411e6

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

geofjamg requested a review from annetill October 31, 2023 12:02

Wip

090c210

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

annetill reviewed Nov 2, 2023

View reviewed changes

geofjamg added 2 commits November 3, 2023 15:46

Merge branch 'main' into automaton2

c72ee2a

Fix

fa6f75c

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

geofjamg requested a review from annetill November 3, 2023 16:05

annetill approved these changes Nov 10, 2023

View reviewed changes

Merge branch 'main' into automaton2

8d96250

# Conflicts: # src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java

geofjamg merged commit 515bbad into main Nov 10, 2023
6 checks passed

geofjamg deleted the automaton2 branch November 10, 2023 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Substation automation system #811

Substation automation system #811

geofjamg commented Jul 3, 2023 •

edited

Loading

sonarqubecloud bot commented Jul 3, 2023

annetill Jul 3, 2023

annetill Jul 3, 2023

geofjamg Oct 16, 2023

annetill Aug 30, 2023

geofjamg Oct 16, 2023

annetill Oct 19, 2023

geofjamg Oct 19, 2023

annetill Oct 20, 2023

annetill Oct 20, 2023

geofjamg Oct 20, 2023

annetill Oct 20, 2023

geofjamg Oct 20, 2023

annetill Oct 20, 2023

geofjamg Oct 20, 2023

annetill Oct 20, 2023

annetill Oct 20, 2023

geofjamg Oct 20, 2023

annetill Oct 20, 2023

geofjamg Oct 20, 2023

annetill Nov 2, 2023 •

edited

Loading

geofjamg Nov 3, 2023

sonarqubecloud bot commented Nov 10, 2023


		OverloadManagementSystemAdder<T> withThreshold(double threshold);

		OverloadManagementSystemAdder<T> withSwitchIdToOperate(String switchId);


		void setEnabled(boolean enabled);

		String getLineIdToMonitor();

Substation automation system #811

Substation automation system #811

Conversation

geofjamg commented Jul 3, 2023 • edited Loading

sonarqubecloud bot commented Jul 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annetill Nov 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 10, 2023

geofjamg commented Jul 3, 2023 •

edited

Loading

annetill Nov 2, 2023 •

edited

Loading