Fix generators update after forcing a bus to remain PV #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandemanged
approved these changes
Jul 13, 2023
caioluke
approved these changes
Jul 17, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
jeandemanged
pushed a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Caio Luke <caio.luke@artelys.com> Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com> (cherry picked from commit aba9c33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
With reactive limits enabled, bus Q balance may be non zero in the case of a bus forced to remain PV.
What is the new behavior (if this is a feature change)?
fixed bus Q balance
Does this PR introduce a breaking change or deprecate an API?
No
Other information:
Note that the solution produced would leave generators outside reactive limits. We may want to revise this strategy in another PR (e.g. make this behavior optional, or flag the component as non converged).