Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculated load Q when distributed slack on loads with constant power factor #815

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Fix calculated load Q when distributed slack on loads with constant power factor #815

merged 3 commits into from
Jul 18, 2023

Conversation

caioluke
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Fix constant power factor when distributing slack on loads

What is the current behavior?

Slack is not correctly distributed on some types of loads, when only the variableReactivePower is not 0.

What is the new behavior (if this is a feature change)?
Slack will always be correctly distributed

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

add test of bug in constant power factor
6466b2a 
Signed-off-by: Caio Luke <caio.luke@artelys.com>
@caioluke caioluke added the bug Something isn't working label Jul 17, 2023
@caioluke caioluke requested a review from annetill July 17, 2023 13:40
@caioluke caioluke self-assigned this Jul 17, 2023
@annetill
Improve unit test and fix proposal.
5e4b024 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill changed the title Fix constant power factor when distributing slack on loads Fix calculated Q when constant power factor Jul 18, 2023
@jeandemanged jeandemanged changed the title Fix calculated Q when constant power factor Fix calculated load Q when distributed slack on loads with constant power factor Jul 18, 2023
@caioluke
Copy link
Member Author

Fix proposal is ok

@annetill annetill requested a review from Hadrien-Godard July 18, 2023 10:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 7996d52 into main Jul 18, 2023
@annetill annetill deleted the fix-constant-power-factor branch July 18, 2023 10:11
jeandemanged pushed a commit that referenced this pull request Jul 18, 2023
@caioluke @jeandemanged
Fix calculated bus load targetQ when distributed slack on loads with …
e997343 
…constant power factor (#815)

Signed-off-by: Caio Luke <caio.luke@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
(cherry picked from commit 7996d52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annetill annetill annetill approved these changes

@Hadrien-Godard Hadrien-Godard Awaiting requested review from Hadrien-Godard

Assignees

@caioluke caioluke

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caioluke @annetill