Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contingency on PST controlled branch causing exception #817

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Fix contingency on PST controlled branch causing exception #817

merged 4 commits into from
Jul 18, 2023

Conversation

jeandemanged
Copy link
Member

@jeandemanged jeandemanged commented Jul 18, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bugfix

What is the current behavior?
Contingency on branch flow regulated by PST causes exception

Does this PR introduce a breaking change or deprecate an API?
No

Other information:

Caused by: com.powsybl.commons.PowsyblException: Expected to have same number of equations (6) and variables (7)
	at com.powsybl.openloadflow.equations.JacobianMatrix.initDer(JacobianMatrix.java:87)
	at com.powsybl.openloadflow.equations.JacobianMatrix.initMatrix(JacobianMatrix.java:113)
	at com.powsybl.openloadflow.equations.JacobianMatrix.getMatrix(JacobianMatrix.java:150)
	at com.powsybl.openloadflow.equations.JacobianMatrix.getLUDecomposition(JacobianMatrix.java:170)
	at com.powsybl.openloadflow.equations.JacobianMatrix.solveTransposed(JacobianMatrix.java:186)
	at com.powsybl.openloadflow.ac.nr.NewtonRaphson.runIteration(NewtonRaphson.java:122)
	at com.powsybl.openloadflow.ac.nr.NewtonRaphson.run(NewtonRaphson.java:311)
	at com.powsybl.openloadflow.ac.AcloadFlowEngine.run(AcloadFlowEngine.java:140)
	at com.powsybl.openloadflow.sa.AcSecurityAnalysis.runPostContingencySimulation(AcSecurityAnalysis.java:241)
	at com.powsybl.openloadflow.sa.AcSecurityAnalysis.lambda$runSimulations$2(AcSecurityAnalysis.java:177)

jeandemanged and others added 4 commits July 18, 2023 09:56
@jeandemanged
reproduce issue
5bf7647 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@annetill
Fix proposal.
9d3c3dc 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill
Merge branch 'main' into fix_contingency_on_PST_controlled_branch
080562a
@jeandemanged
add results assertions on test case
11583e3 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged
Copy link
Member Author

thanks a lot @annetill , all good for me

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 5273672 into main Jul 18, 2023
@annetill annetill deleted the fix_contingency_on_PST_controlled_branch branch July 18, 2023 10:28
jeandemanged added a commit that referenced this pull request Jul 18, 2023
@jeandemanged
Fix contingency on phase shifter controlled branch causing exception (#…
ae4a459 
…817)

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Co-authored-by: Anne Tilloy <anne.tilloy@rte-france.com>
(cherry picked from commit 5273672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annetill annetill annetill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeandemanged @annetill