Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC approximation type configuration #878

Merged
merged 9 commits into from
Oct 23, 2023
Merged

DC approximation type configuration #878

merged 9 commits into from
Oct 23, 2023

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Oct 8, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

In the DC approx simulation, we consider that r << x to simplify equations.

What is the new behavior (if this is a feature change)?
In the DC approx simulation, we could also by a parameter consider that g << b to simplify equations.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java
#	src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java
#	src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java
#	src/test/resources/debug-parameters.json
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.1% 96.1% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit 44c0f18 into main Oct 23, 2023
@geofjamg geofjamg deleted the dc_approx_type branch October 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants