Fix NPE on VSC without a HVDC line #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
annetill
reviewed
Dec 5, 2023
| @@ -78,12 +79,14 @@ public double getTargetQ() { | |||
|
|
|||
| @Override | |||
| public double getMinP() { | |||
| return -getStation().getHvdcLine().getMaxP() / PerUnit.SB; | |||
| HvdcLine hvdcLine = getStation().getHvdcLine(); | |||
| return hvdcLine != null ? -hvdcLine.getMaxP() / PerUnit.SB : -Double.MAX_VALUE; | |||
There was a problem hiding this comment.
It is not needed as you cannot have a VSC without any HVDC line in network loading.
There was a problem hiding this comment.
I had a failing test without adding it.
There was a problem hiding this comment.
ok, see #691 for a better solution about hvdc line.
annetill
approved these changes
Dec 5, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
We get a NPE when HVDC emulation is activated and we have a VSC or LCC converter station without a HVDC line.
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: