Bug in reactive power dispatching

src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowGeneratorTest.java

@@ -0,0 +1,71 @@
+/**
+ * Copyright (c) 2024, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+package com.powsybl.openloadflow.ac;
+
+import com.powsybl.iidm.network.*;
+import com.powsybl.loadflow.LoadFlow;
+import com.powsybl.loadflow.LoadFlowParameters;
+import com.powsybl.loadflow.LoadFlowResult;
+import com.powsybl.math.matrix.DenseMatrixFactory;
+import com.powsybl.openloadflow.OpenLoadFlowParameters;
+import com.powsybl.openloadflow.OpenLoadFlowProvider;
+import com.powsybl.openloadflow.network.FourBusNetworkFactory;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
+import static org.junit.jupiter.api.Assertions.*;
+
+/**
+ * @author Anne Tilloy {@literal <anne.tilloy at rte-france.com>}
+ */
+class AcLoadFlowGeneratorTest {
+    private LoadFlow.Runner loadFlowRunner;
+    private LoadFlowParameters parameters;
+    private OpenLoadFlowParameters parametersExt;
+
+    @BeforeEach
+    void setUp() {
+        loadFlowRunner = new LoadFlow.Runner(new OpenLoadFlowProvider(new DenseMatrixFactory()));
+        parameters = new LoadFlowParameters();
+        parametersExt = OpenLoadFlowParameters.create(parameters);
+    }
+
+    @Test
+    void testWithCondenser() {
+        Network network = FourBusNetworkFactory.createWithCondenser();
+        Bus b1 = network.getBusBreakerView().getBus("b1");
+        Bus b4 = network.getBusBreakerView().getBus("b4");
+        parameters.setBalanceType(LoadFlowParameters.BalanceType.PROPORTIONAL_TO_LOAD);
+        LoadFlowResult result = loadFlowRunner.run(network, parameters);
+        assertTrue(result.isFullyConverged());
+        assertVoltageEquals(1.0, b1);
+        assertAngleEquals(0, b1);
+        assertVoltageEquals(1.0, b4);
+        assertAngleEquals(-2.584977, b4);
+    }
+
+    @Test
+    void testGeneratorDiscardedFromVoltageControl() {
+        Network network = FourBusNetworkFactory.createWith2GeneratorsAtBus1();
+        Generator g1Bis = network.getGenerator("g1Bis").setTargetP(0.0).setMinP(1.0).setTargetQ(Double.NaN); // must be discarded from voltage control
+        Bus b1 = network.getBusBreakerView().getBus("b1");
+        Bus b4 = network.getBusBreakerView().getBus("b4");
+        Generator g1 = network.getGenerator("g1");
+        parameters.setBalanceType(LoadFlowParameters.BalanceType.PROPORTIONAL_TO_LOAD);
+        LoadFlowResult result = loadFlowRunner.run(network, parameters);
+        assertTrue(result.isFullyConverged());
+        assertVoltageEquals(1.0, b1);
+        assertAngleEquals(0, b1);
+        assertVoltageEquals(1.0, b4);
+        assertAngleEquals(-1.452245, b4);
+        assertReactivePowerEquals(Double.NaN, g1Bis.getTerminal()); // FIXME
+        assertReactivePowerEquals(0.0, g1.getTerminal()); // FIXME
+    }
+}
+

src/test/java/com/powsybl/openloadflow/network/FourBusNetworkFactory.java

@@ -179,5 +179,14 @@ public static Network createWithAdditionalReactiveTerms() {
         g3.setRegulatingTerminal(network.getLine("l24").getTerminal2());
         return network;
     }
+
+    public static Network createWithCondenser() {
+        Network network = createBaseNetwork();
+        network.getGenerator("g4")
+                .setTargetP(0.0)
+                .setMaxP(0.0)
+                .setMinP(0.0);
+        return network;
+    }
 }