-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rao Parameters: separate business from implementation specific #1101
base: rao_parameters_merge_type_and_preventive_stop_criterion
Are you sure you want to change the base?
Conversation
23e045e
to
f307d78
Compare
27fdbce
to
06d212b
Compare
f7a70a8
to
01ec4ab
Compare
63fc61f
to
a24cff9
Compare
5bee729
to
9a19a7c
Compare
b84b8ce
to
66dc9dc
Compare
66dc9dc
to
c760e7a
Compare
8810fed
to
4e59f6b
Compare
c760e7a
to
65aabf0
Compare
4e59f6b
to
68f03a1
Compare
@@ -102,7 +102,7 @@ public void setUp() { | |||
when(parameters.getMaxNumberOfIterations()).thenReturn(5); | |||
RangeActionsOptimizationParameters rangeActionParameters = Mockito.mock(RangeActionsOptimizationParameters.class); | |||
when(rangeActionParameters.getPstModel()).thenReturn(RangeActionsOptimizationParameters.PstModel.CONTINUOUS); | |||
when(parameters.getRangeActionParameters()).thenReturn(rangeActionParameters); | |||
//when(parameters.getRangeActionParameters()).thenReturn(rangeActionParameters); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
jsonGenerator.writeEndObject(); | ||
} | ||
|
||
static void deserialize(JsonParser jsonParser, OpenRaoSearchTreeParameters searchTreeParameters) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general comment for all serialization / deserialization. I think it would be better to fully use jackson and StdSerializer / StdDeserializer. Maybe some work for another PR.
adbcbb2
to
8f911c7
Compare
68f03a1
to
448cd9e
Compare
8f911c7
to
f000bd9
Compare
448cd9e
to
f3fd6b2
Compare
…one extension (to have a flat yml for platform config) Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
f000bd9
to
b9b4fc3
Compare
… acceptable)
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#1084
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: