Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rao Parameters: separate business from implementation specific #1101

Open
wants to merge 13 commits into
base: rao_parameters_merge_type_and_preventive_stop_criterion
Choose a base branch
from
Open

Rao Parameters: separate business from implementation specific #1101

wants to merge 13 commits into from

Conversation

pjeanmarie
Copy link
Member

… acceptable)

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@pjeanmarie pjeanmarie changed the title Rao Parameters: separate business from implementation specific WIP: Rao Parameters: separate business from implementation specific Jul 31, 2024
@pjeanmarie pjeanmarie linked an issue Aug 5, 2024 that may be closed by this pull request
Make RaoParameters generic #1084
Open
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch from 23e045e to f307d78 Compare August 5, 2024 16:31
@pet-mit pet-mit mentioned this pull request Aug 6, 2024
Open
@pjeanmarie pjeanmarie marked this pull request as draft August 9, 2024 15:57
@pjeanmarie pjeanmarie removed a link to an issue Aug 9, 2024
Make RaoParameters generic #1084
Open
@pjeanmarie pjeanmarie changed the title WIP: Rao Parameters: separate business from implementation specific [WIP] Rao Parameters: separate business from implementation specific Aug 9, 2024
@pjeanmarie pjeanmarie linked an issue Sep 23, 2024 that may be closed by this pull request
Make RaoParameters generic #1084
Open
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch 2 times, most recently from 27fdbce to 06d212b Compare September 25, 2024 13:29
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch 3 times, most recently from f7a70a8 to 01ec4ab Compare October 8, 2024 14:35
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch 4 times, most recently from 63fc61f to a24cff9 Compare October 15, 2024 13:27
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch 4 times, most recently from 5bee729 to 9a19a7c Compare October 23, 2024 16:26
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch 2 times, most recently from e2d19b0 to b84b8ce Compare October 28, 2024 10:06
Pauline Jean-Marie and others added 7 commits October 28, 2024 11:18
ForbidCostIncrease should always be true (for the optim results to be…
c9a193e 
… acceptable)

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Repair tests
b1a5757 
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Remove curative stop criterion and 'optimize curative if preventive u…
9ad0337 
…nsecure' and partially replace them by 'enforce curative security'

NB. Curative min objective does no longer exist and is replaced by Curative have the same objective than the Preventive results

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Remove unit from functional objective parameters and use MEGAWATT whe…
7c44adf 
…n 'is DC' otherwise AMPERE from load flow sensitivity parameters

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
@phiedw
started changing cucumber tests following Pauline's devs on rao param…
c301aff 
…eters

Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Repair cucumber tests often by using the value of DC to have the corr…
802f70b 
…ect Unit

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Merge content of preventive stop criterion into type
8810fed 
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Pauline Jean-Marie added 5 commits October 28, 2024 16:31
Change extension config load to be able to have multiple modules for …
c04790a 
…one extension (to have a flat yml for platform config)

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Update test to be more explicit on the unexpected values
c999156 
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Move implem specific rao parameters into extensions: change script
c2378dc 
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Move implem specific rao parameters into extensions: update json
d0313e4 
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Move implem specific rao parameters into extensions: update yml
759e9f4 
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch from b84b8ce to 66dc9dc Compare October 28, 2024 16:10
Move implem specific rao parameters into extensions
c760e7a 
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch from 66dc9dc to c760e7a Compare November 4, 2024 10:01
@pjeanmarie pjeanmarie changed the base branch from main to rao_parameters_merge_type_and_preventive_stop_criterion November 5, 2024 09:18
@pjeanmarie pjeanmarie changed the title [WIP] Rao Parameters: separate business from implementation specific Rao Parameters: separate business from implementation specific Nov 5, 2024
@pjeanmarie pjeanmarie added breaking-change Changes could break users' code PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) labels Nov 5, 2024
@pjeanmarie pjeanmarie marked this pull request as ready for review November 5, 2024 09:19
@pet-mit pet-mit mentioned this pull request Nov 14, 2024
Open
7 tasks
@pjeanmarie pjeanmarie force-pushed the rao_parameters_merge_type_and_preventive_stop_criterion branch from 8810fed to 4e59f6b Compare November 19, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Changes could break users' code PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make RaoParameters generic
2 participants
@pjeanmarie @phiedw