Rao parameters use unit from is dc #1140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjeanmarie
changed the title
pjeanmarie
force-pushed
the
rao_parameters_remove_curative_stop_criterion
branch
from
22ef4cf
to
30c511d
Compare
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
3 times, most recently
from
5ce3d76
to
1706a08
Compare
pjeanmarie
force-pushed
the
rao_parameters_remove_curative_stop_criterion
branch
from
30c511d
to
443782c
Compare
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
from
1706a08
to
7f7e969
Compare
pjeanmarie
force-pushed
the
rao_parameters_remove_curative_stop_criterion
branch
2 times, most recently
from
dcc85bc
to
7d68245
Compare
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
2 times, most recently
from
b65e806
to
54aa50a
Compare
bqth29
reviewed
Oct 9, 2024
| @@ -5,21 +5,21 @@ | |||
|
|
|||
| Feature: US 10.1: Linear RAO with relative margin | |||
|
|
|||
| @fast @rao @mock @ac @preventive-only @relative | |||
| @fast @rao @mock @dc @preventive-only @relative | |||
There was a problem hiding this comment.
Is there a reason you moved from AC to DC? I am affraid this will change the LF results which could alter the test's results
There was a problem hiding this comment.
The same question goes for all the other tests, I would rather convert by hand the objective value from MW to A instead of changing the LF computation mode
what do you think @phiedw?
There was a problem hiding this comment.
This dev will be replaced by a separate unit parameter in rao parameter, then no change in tests behavior is expected.
added 3 commits
October 28, 2024 11:18
… acceptable) Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
…nsecure' and partially replace them by 'enforce curative security' NB. Curative min objective does no longer exist and is replaced by Curative have the same objective than the Preventive results Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
pjeanmarie
force-pushed
the
rao_parameters_remove_curative_stop_criterion
branch
from
7d68245
to
9ad0337
Compare
…n 'is DC' otherwise AMPERE from load flow sensitivity parameters Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
…eters Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
…ect Unit Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
pjeanmarie
force-pushed
the
rao_parameters_use_unit_from_is_dc
branch
from
54aa50a
to
802f70b
Compare
pjeanmarie
changed the title
pjeanmarie
added
breaking-change
pjeanmarie
force-pushed
the
rao_parameters_remove_curative_stop_criterion
branch
2 times, most recently
from
43b027a
to
78c32dc
Compare
pjeanmarie
removed
PR : dont-merge-before-other
pjeanmarie
added
the
experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
MAX_MIN_MARGIN_IN_MEGAWATT and MAX_MIN_MARGIN_IN_AMPERE are now MAX_MIN_MARGIN
MAX_MIN_RELATIVE_MARGIN_IN_MEGAWATT and MAX_MIN_RELATIVE_MARGIN_IN_AMPERE are now MAX_MIN_RELATIVE_MARGIN
the unit is computed from load-flow-and-sensitivity-computation -> sensitivity-parameters -> load-flow-parameters -> dc
if dc true we have MEGAWATT if false we have AMPERE
Other information: