Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rao parameters put back some extensions values into rao parameters #1191

Open
wants to merge 6 commits into
base: rao_parameters_separate_business_and_implem_specific
Choose a base branch
from
Open

Rao parameters put back some extensions values into rao parameters #1191

wants to merge 6 commits into from

Conversation

pjeanmarie
Copy link
Member

@pjeanmarie pjeanmarie commented Nov 5, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

#1084

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

    if "extensions" in data:
        move_back_to_rao_param(data, "mnec-parameters", ["acceptable-margin-decrease"])
        move_back_to_rao_param(data, "relative-margins-parameters", ["ptdf-boundaries"])
        move_back_to_rao_param(data, "loop-flow-parameters", ["acceptable-increase", "countries"])

Other information:

@pjeanmarie pjeanmarie added breaking-change Changes could break users' code PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) labels Nov 5, 2024
@pjeanmarie pjeanmarie force-pushed the rao_parameters_put_back_some_extensions_values_into_rao_parameters branch 3 times, most recently from ab87fce to 0fc71d9 Compare November 12, 2024 14:30
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch from c760e7a to 65aabf0 Compare November 21, 2024 09:48
@pjeanmarie pjeanmarie force-pushed the rao_parameters_put_back_some_extensions_values_into_rao_parameters branch 2 times, most recently from 48b9467 to efc4bd4 Compare November 21, 2024 14:44
@pjeanmarie pjeanmarie changed the title Rao parameters put back some extensions values into rao parameters WIP: Rao parameters put back some extensions values into rao parameters Nov 21, 2024
@pjeanmarie pjeanmarie force-pushed the rao_parameters_put_back_some_extensions_values_into_rao_parameters branch from efc4bd4 to ec5f3f7 Compare November 25, 2024 10:45
@pjeanmarie pjeanmarie changed the title WIP: Rao parameters put back some extensions values into rao parameters Rao parameters put back some extensions values into rao parameters Nov 25, 2024
@pjeanmarie pjeanmarie added the PR: waiting-for-review This PR is waiting to be reviewed label Nov 25, 2024
@pjeanmarie pjeanmarie requested a review from obrix November 25, 2024 10:55
@pjeanmarie pjeanmarie linked an issue Nov 25, 2024 that may be closed by this pull request
Make RaoParameters generic #1084
Open
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch from adbcbb2 to 8f911c7 Compare November 29, 2024 09:32
@pjeanmarie pjeanmarie force-pushed the rao_parameters_put_back_some_extensions_values_into_rao_parameters branch from ec5f3f7 to b4859b0 Compare November 29, 2024 09:36
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch from 8f911c7 to f000bd9 Compare November 29, 2024 10:20
@pjeanmarie pjeanmarie force-pushed the rao_parameters_put_back_some_extensions_values_into_rao_parameters branch 2 times, most recently from a8d93d4 to 419b2e9 Compare November 29, 2024 13:53
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch from f000bd9 to b9b4fc3 Compare December 9, 2024 13:04
Pauline Jean-Marie added 2 commits December 9, 2024 14:17
Separate previous extensions in business/search-tree as optional
f4799a1 
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
To have same behavior than before change on extensions: create defaul…
e3a19d0 
…t values in extension if exist in rao-parameters and vive-versa

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
@pjeanmarie pjeanmarie force-pushed the rao_parameters_put_back_some_extensions_values_into_rao_parameters branch from 419b2e9 to e3a19d0 Compare December 9, 2024 13:18
phiedw
phiedw requested changes Jan 10, 2025
View reviewed changes
docs/parameters.md Outdated
@@ -124,6 +124,68 @@ optimisation of specific CNECs in specific conditions.
This parameter has no effect on the preventive RAO.
This parameter should be set to true for CORE CC.

### Loop-flow optional parameter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be clearer to actually separate the specific parameters to a second page. The main parameters page would explain how we now have implementation specific parameters and business parameters, and then two sub pages for the business ones and the specific ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ra-optimisation/rao-api/src/main/java/com/powsybl/openrao/raoapi/parameters/MnecParameters.java Outdated
});
}

//TODO to remove
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this todo to be done in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, I removed it

@phiedw
Merge branch 'rao_parameters_separate_business_and_implem_specific' of …
0c862ab 
…https://github.com/powsybl/open-rao into rao_parameters_put_back_some_extensions_values_into_rao_parameters

Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
@pjeanmarie
Copy link
Member Author

@phiedw I think I should change the class name identical in parameters and the extension as we do before (for example SearchTreeRaoRangeActionsOptimizationParameters in rao_parameters_separate_business_and_implem_specific). So I will rename:

  • MnecParameters -> SearchTreeRaoMnecParameters
  • RelativeMarginsParameters -> SearchTreeRaoRelativeMarginsParameters
  • LoopFlowParameters -> SearchTreeRaoLoopFlowParameters

@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_business_and_implem_specific branch from 07511dd to 0058ddc Compare January 17, 2025 09:03
Pauline Jean-Marie added 3 commits January 17, 2025 10:15
Merge branch 'rao_parameters_separate_business_and_implem_specific' i…
01540b0 
…nto rao_parameters_put_back_some_extensions_values_into_rao_parameters
Rename to avoid having same class name in rao parameters and its exte…
4d4cf0f 
…nsion

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Separate rao parameters doc in multiple pages
977faa2 
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
@pjeanmarie pjeanmarie force-pushed the rao_parameters_put_back_some_extensions_values_into_rao_parameters branch from 2bf7b61 to 977faa2 Compare January 17, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phiedw phiedw phiedw requested changes

@obrix obrix Awaiting requested review from obrix

Assignees
No one assigned
Labels
breaking-change Changes could break users' code PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make RaoParameters generic
2 participants
@pjeanmarie @phiedw