Cleaning/intertemporal features cleaner #1289
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: CHEN Roxane <roxane.chen@rte-france.com>
…cleaner' into cleaning/intertemporal-features-cleaner
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Godelaine
requested changes
Mar 3, 2025
| /** | ||
| * @author Thomas Bouquet {@literal <thomas.bouquet at rte-france.com>} | ||
| * @author Roxane Chen {@literal <roxane.chen at rte-france.com>} | ||
| */ |
There was a problem hiding this comment.
MaxCostEvaluatorResult seems obsolete. AbstractStateWiseCostEvaluatorResult needs to be merged with SumCostEvaluator or adapted to be abstract with SumMaxPerTimestamp
| LinearOptimizationResult linearOptimizationResults = optimizeLinearRemedialActions(raoInput, prePerimeterResults, raoParameters, getPreventiveTopologicalActions(raoInput.getRaoInputs().map(RaoInput::getCrac), topologicalOptimizationResults)); | ||
| // 4. Build objective function and initial result | ||
| ObjectiveFunction objectiveFunction = buildGlobalObjectiveFunction(raoInput.getRaoInputs().map(RaoInput::getCrac), new GlobalFlowResult(prePerimeterResults.map(PrePerimeterResult::getFlowResult)), raoParameters); | ||
| TemporalData<NetworkActionsResult> preventiveTopologicalActions = getPreventiveNetworkActions(topologicalOptimizationResults, raoInput.getRaoInputs().map(RaoInput::getCrac)); |
There was a problem hiding this comment.
use getPreventiveTopologicalActions
| // 5. Merge topological and linear result | ||
| // 5. Create and iteratively solve MIP to find optimal range actions' set-points | ||
| OpenRaoLoggerProvider.TECHNICAL_LOGS.info("[MARMOT] ----- Global range actions optimization [start]"); | ||
| LinearOptimizationResult linearOptimizationResults = optimizeLinearRemedialActions(raoInput, prePerimeterResults, raoParameters, getPreventiveTopologicalActions(raoInput.getRaoInputs().map(RaoInput::getCrac), topologicalOptimizationResults), objectiveFunction); |
There was a problem hiding this comment.
use preventiveTopologicalActions
| @@ -70,4 +70,8 @@ public Map<PstRangeAction, Integer> getOptimizedTapsOnState(State state) { | |||
| public int getTapVariation(PstRangeAction pstRangeAction, State state) { | |||
| return MarmotUtils.getDataFromState(rangeActionActivationPerTimestamp, state).getTapVariation(pstRangeAction, state); | |||
| } | |||
|
|
|||
| public TemporalData<RangeActionActivationResult> getRangeActionActivationPerTimestamp() { | |||
| } | ||
|
|
||
| @Test | ||
| public void testEvaluator() { |
There was a problem hiding this comment.
please add comments detailing expected results
| @@ -27,14 +27,15 @@ | |||
| import java.util.Set; | |||
|
|
|||
| import static org.junit.jupiter.api.Assertions.assertEquals; | |||
| import static org.junit.jupiter.api.Assertions.assertTrue; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: