Voltage limit override new version #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: parvy <pierre.arvy@artelys.com>
… voltage level has defined low/high voltage limits (taking into account voltage limit overrides) Signed-off-by: parvy <pierre.arvy@artelys.com>
p-arvy
changed the title
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
annetill
reviewed
Oct 10, 2023
| @@ -165,7 +165,9 @@ public OpenReacParameters createOpenReacParameters(CommandLine line, | |||
| String voltageId = node.get("id").asText(); | |||
| double lowerPercent = node.get("lower").asDouble(); | |||
| double upperPercent = node.get("upper").asDouble(); | |||
| openReacParameters.addSpecificVoltageLimits(Map.of(voltageId, new VoltageLimitOverride(lowerPercent, upperPercent))); | |||
There was a problem hiding this comment.
@geofjamg can we delete the tool now? If yes, I will dot that in a other PR.
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
p-arvy
changed the title
...src/main/java/com/powsybl/openreac/parameters/input/json/VoltageLimitOverrideSerializer.java
Outdated
Show resolved
Hide resolved
| String voltageLevelId = null; | ||
| VoltageLimitOverride.VoltageLimitType type = null; | ||
| boolean isRelative = true; | ||
| double overrideValue = 0; |
There was a problem hiding this comment.
You might want to initialize to Double.NaN and then the check that the value is in the file will be done when calling the constructor.
There was a problem hiding this comment.
Yes, but @p-arvy value must be defined ad so checked at construction.
| break; | ||
| case "isRelative": | ||
| parser.nextToken(); | ||
| isRelative = parser.readValueAs(boolean.class); |
| double deltaHighVoltageLimit = 0; | ||
| String voltageLevelId = null; | ||
| VoltageLimitOverride.VoltageLimitType type = null; | ||
| boolean isRelative = true; |
There was a problem hiding this comment.
You might also want to initialize this boolean to null, for that you can use Boolean instead. Or do you want isRelative to have a default value to true if the field is not in the file?
Then you can add a check that isRelative is well defined and if not throw an exception because it's undefined.
Signed-off-by: parvy <pierre.arvy@artelys.com>
…ater than high limit. Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
colinepiloquet
approved these changes
Oct 19, 2023
annetill
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
Other information: