Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump core 6.0.1 #34

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Bump core 6.0.1 #34

merged 3 commits into from
Oct 19, 2023

Conversation

olperr1
Copy link
Member

@olperr1 olperr1 commented Oct 19, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Dependency update

What is the current behavior?

powsybl-optimizer uses:

  • powsybl-core 5.3.2
  • powsybl-open-loadflow 1.2.1

What is the new behavior (if this is a feature change)?
powsybl-optimizer uses:

  • powsybl-core 6.0.1
  • powsybl-open-loadflow 1.3.0

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

List<String> lines = null;
try {
lines = Files.readAllLines(path);
} catch (IOException e) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a little difference here.

Previously, no exception was thrown when an IOException was thrown during readAllLines .

Now, no exception is thrown when the file is not a regular file (real file + read access on it), but if another IOException is thrown, it will be propagated as an UncheckedIOException by the caller (see AmplModelExecutionHandler.readCustomFiles in powsybl-core). But I don't know if it can really happen.

annetill and others added 3 commits October 19, 2023 14:55
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 82095c9 into main Oct 19, 2023
7 checks passed
@olperr1 olperr1 deleted the bump-core-6.0.1 branch October 23, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants