Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove addAlgorithmParam / getAlgorithmParam methods from OpenReacParameters #44

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Remove addAlgorithmParam / getAlgorithmParam methods from OpenReacParameters #44

merged 1 commit into from
Nov 17, 2023

Conversation

annetill
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@annetill
Remove addAlgorithmParam.
71e5944 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill requested a review from geofjamg November 17, 2023 09:31
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@annetill annetill requested a review from p-arvy November 17, 2023 09:39
@annetill annetill added the Breaking change API is broken label Nov 17, 2023
@annetill annetill merged commit f388d67 into main Nov 17, 2023
7 checks passed
@olperr1 olperr1 changed the title Remove addAlgorithmParam method Remove addAlgorithmParam / addAlgorithmParam methods from OpenReacParameters Nov 27, 2023
@olperr1 olperr1 changed the title Remove addAlgorithmParam / addAlgorithmParam methods from OpenReacParameters Remove addAlgorithmParam / getAlgorithmParam methods from OpenReacParameters Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-arvy p-arvy p-arvy approved these changes

@geofjamg geofjamg Awaiting requested review from geofjamg

Assignees
No one assigned
Labels
Breaking change API is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annetill @p-arvy