Add concise and detailed logs for missing or inconsistent voltage levels limits. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add synthetic and detailed logs for inconsistent voltage levels limits (limit < 0 and low limit > high limit) Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
So-Fras
requested changes
May 13, 2024
open-reac/src/main/java/com/powsybl/openreac/OpenReacRunner.java
Outdated
Show resolved
Hide resolved
open-reac/src/main/java/com/powsybl/openreac/OpenReacRunner.java
Outdated
Show resolved
Hide resolved
So-Fras
changed the title
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
|
Refactoring done to remove sonar issues. |
So-Fras
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Feature
What is the current behavior?
When there are voltage levels without limits, and also when there are inconsistencies in the limits (limit < 0 or low limit > high limit),
an exception is just thrown, and we have no information about the concerned voltage levels.
What is the new behavior (if this is a feature change)?
Synthetic and detailed reports are now created for missing or inconsistent voltage levels limits, before the exception is thrown, in order to help the user to correct his data.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: