Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G/B to 0 for non-impedant branches in AMPL #75

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Jul 29, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

The conductance/susceptance of the non-impedant branches are set to 0.

What is the current behavior?

These values are used as such for the non-impedant branches. Some values are huge due to per unitage.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@p-arvy p-arvy changed the title [WIP] G/B to 0 for non-impedant branches in AMPL G/B to 0 for non-impedant branches in AMPL Jul 30, 2024
Copy link

@p-arvy p-arvy requested a review from So-Fras July 30, 2024 16:32
@So-Fras So-Fras merged commit ae78bb3 into main Jul 31, 2024
6 checks passed
@So-Fras So-Fras deleted the no-g-b-on-nonimpedant-branches branch July 31, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants