Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to readthedocs #85

Merged
merged 14 commits into from
Dec 5, 2024
Merged

Migration to readthedocs #85

merged 14 commits into from
Dec 5, 2024

Conversation

So-Fras
Copy link
Member

@So-Fras So-Fras commented Nov 27, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

What kind of change does this PR introduce?
Documentation migration to readthedocs

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras So-Fras changed the title [WIP] Migration to readthedocs Migration to readthedocs Dec 3, 2024
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras So-Fras marked this pull request as ready for review December 3, 2024 12:16
@So-Fras So-Fras self-assigned this Dec 3, 2024
Copy link
Member

@p-arvy p-arvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your work, @So-Fras!
Just minor comments related to improving the LaTeX formatting.

docs/optimizer/acOptimalPowerflow.md Outdated Show resolved Hide resolved
docs/optimizer/acOptimalPowerflow.md Outdated Show resolved Hide resolved
docs/optimizer/acOptimalPowerflow.md Outdated Show resolved Hide resolved
docs/optimizer/preprocessing.md Outdated Show resolved Hide resolved
So-Fras and others added 4 commits December 3, 2024 17:04
Co-authored-by: p-arvy <126792538+p-arvy@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Co-authored-by: p-arvy <126792538+p-arvy@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Co-authored-by: p-arvy <126792538+p-arvy@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Co-authored-by: p-arvy <126792538+p-arvy@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Copy link
Member

@colinepiloquet colinepiloquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice documentation! I like the part that explains how to make references to other pages from other read the docs. I mostly found a few words to modify but it's not that troublesome.

docs/optimizer/acOptimalPowerflow.md Outdated Show resolved Hide resolved
docs/optimizer/dcOptimalPowerflow.md Outdated Show resolved Hide resolved
docs/optimizer/divisionOfCode.md Outdated Show resolved Hide resolved
docs/optimizer/outputs.md Outdated Show resolved Hide resolved
docs/optimizer/outputs.md Outdated Show resolved Hide resolved
docs/optimizer/slackBusMainConnexComponent.md Outdated Show resolved Hide resolved
So-Fras and others added 6 commits December 5, 2024 09:32
Co-authored-by: Coline Piloquet <55250145+colinepiloquet@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Co-authored-by: Coline Piloquet <55250145+colinepiloquet@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Co-authored-by: Coline Piloquet <55250145+colinepiloquet@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Co-authored-by: Coline Piloquet <55250145+colinepiloquet@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
…optimizer into add_readthedocs

Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Copy link

sonarqubecloud bot commented Dec 5, 2024

@So-Fras So-Fras merged commit 07ea633 into main Dec 5, 2024
7 checks passed
@So-Fras So-Fras deleted the add_readthedocs branch December 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants