Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reproducible builds by default #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jonenst
Copy link
Contributor

@jonenst jonenst commented Jul 22, 2022

Signed-off-by: HARPER Jon jon.harper87@gmail.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
NO

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bugfix

What is the current behavior? (You can also link to an open issue here)
by default builds are not byte for byte reproducible (jar, docker images, itools packager zip)

What is the new behavior (if this is a feature change)?
by default builds are byte for byte reproducible (jar, docker images, itools packager zip)

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
NO

Other information:
needs a fix for itools packager, and a change in the code that puts the real current time in a java-template in powsybl-core/tool or other projecst ( @autoservice(Version.class) system)

Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
@olperr1
Copy link
Member

olperr1 commented Jun 15, 2023

Note that starting with release 2.9.0 of versions-maven-plugin, versions:set goal updates the project.build.outputTimestamp property (source).
#38 will upgrade the plugin to a version supporting this mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants