-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lombok configuration on Windows #55
Conversation
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for the feedback, is it working in pure beanshell?
@olperr1 Tested on windows, it fixes the build issue. |
…ugin task Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me! 👍🏻
Thank you for your returns, @Tristan-WorkGH, @obrix, @jonenst |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When a project uses the lombok common configuration introduced by #44, the compilation fails on Windows because of the
\
which are contained in the project path.What is the new behavior (if this is a feature change)?
The compilation must not fail and the common configuration must be taken into account.
Does this PR introduce a breaking change or deprecate an API?
Other information:
For instance, when compiling
powsybl-networkstore
on Windows, if the project is located inC:\Path_to\powsybl-network-store
, the error message (before this fix) is: