Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liquibase-hibernate version to 4.26.0 #58

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

anistouri
Copy link
Contributor

@anistouri anistouri commented Apr 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Dependency update

What is the current behavior?

Use liquibase-hibernate6 4.23.2.

What is the new behavior (if this is a feature change)?
Use liquibase-hibernate6 4.26.0

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

Switching to liquibase-hibernate 4.26.0, which includes resolving the issue where it attempted to connect to the database during changelog generation.
This connection issue has been corrected in version 4.26.0, along with potential additional bug fixes and enhancements.

Signed-off-by: TOURI ANIS <anis-1.touri@rte-france.com>
Comment on lines 68 to +73
<column name="myuuid" type="UUID">
still generates
<modifyDataType columnName="myuuid" newDataType="bytea"/>

Switching to liquibase-hibernate.version 4.26.0, which includes resolving the issue where it attempted to connect to the database during changelog generation.
This connection issue has been corrected in version 4.26.0, along with potential additional bug fixes and enhancements.
Copy link
Member

@Tristan-WorkGH Tristan-WorkGH Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the problem explain above?
If yes, you can remove fully the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the comment to track and explain why there is a difference between the versions of liquibase.core and liquibase.hibernate

-->
<liquibase-hibernate.version>4.23.2</liquibase-hibernate.version>
<liquibase-hibernate.version>4.26.0</liquibase-hibernate.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<liquibase-hibernate.version>4.26.0</liquibase-hibernate.version>
<liquibase-hibernate.version>4.27.0</liquibase-hibernate.version>

from the releases, it's not the last version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version that contains the fix we made on the liquibase-hibernate repo and also I avoid taking the latest version

@SlimaneAmar
Copy link

@olperr1 Can you merge this PR please ?

@olperr1 olperr1 merged commit 8e10a47 into main Apr 26, 2024
2 checks passed
@olperr1 olperr1 deleted the upgrade-liquibase-hibernate-to-4.26.0 branch April 26, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants